Context Navigation

← Previous Ticket
Next Ticket →

Opened at 2013-05-09T15:54:18Z

Closed at 2014-09-02T21:52:10Z

#1966 closed enhancement (fixed)

WUI: new directory page

Reported by:	daira	Owned by:	warner
Priority:	normal	Milestone:	1.10.1
Component:	code-frontend-web	Version:	1.10.0
Keywords:	wui aesthetics directory	Cc:
Launchpad Bug:

Description (last modified by daira)

Update the directory page's style to match that of the welcome page.

Change History (16)

comment:1 Changed at 2013-05-09T15:56:49Z by tarcieri

Owner set to tarcieri

Work in progress here:

https://github.com/tahoe-lafs/tahoe-lafs/pull/32

and rebased to trunk, here:

https://github.com/daira/tahoe-lafs/commits/1966-redesigned-directory-page

Last edited at 2013-05-11T00:08:58Z by daira (previous) (diff)

comment:2 Changed at 2013-05-11T00:03:48Z by daira

Description modified (diff)

comment:3 Changed at 2013-08-19T18:20:06Z by markberger

Is there anything preventing this ticket from landing in 1.11? I would like to see this committed to trunk and I'm more than willing to help.

comment:4 Changed at 2013-08-19T18:26:34Z by tarcieri

It's not completely finished yet. If you take a look at it you'll see that the forms at the bottom are not rendering correctly. They need to be converted to a style similar to the welcome page

comment:5 Changed at 2013-08-30T14:45:06Z by markberger

I opened a pull request on Tony's pull request to fix the forms.

The allmydata.test.test_sftp unit test is broken on my branch but I believe it is fixed when the branch is rebased to trunk.

Last edited at 2013-08-30T14:47:09Z by markberger (previous) (diff)

comment:6 Changed at 2013-08-30T14:52:50Z by markberger

Milestone changed from soon to 1.11.0

Now that the forms are fixed, I'm hoping we can get this into 1.11.

comment:7 Changed at 2013-08-30T14:58:51Z by daira

Keywords review-needed added
Owner tarcieri deleted

comment:8 Changed at 2013-09-10T00:39:08Z by tarcieri

I updated my branch with markberger's contributions. This should be mergeable now.

comment:9 Changed at 2013-09-16T23:50:21Z by markberger

I reviewed everything Tony and Leif wrote for this patch and it looks good. Once someone reviews my part of the patch, this can be merged (it should take less than five minutes).