Opened at 2013-05-09T15:54:18Z

Closed at 2014-09-02T21:52:10Z

#1966 closed enhancement (fixed)

WUI: new directory page

Reported by: daira Owned by: warner
Priority: normal Milestone: 1.10.1
Component: code-frontend-web Version: 1.10.0
Keywords: wui aesthetics directory Cc:
Launchpad Bug:

Description (last modified by daira)

Update the directory page's style to match that of the welcome page.

Change History (16)

comment:1 Changed at 2013-05-09T15:56:49Z by tarcieri

  • Owner set to tarcieri

Update the directory page's style to match that of the welcome page.

Work in progress here:

​https://github.com/tahoe-lafs/tahoe-lafs/pull/32#issuecomment-14983398

Version 0, edited at 2013-05-09T15:56:49Z by tarcieri (next)

comment:2 Changed at 2013-05-11T00:03:48Z by daira

  • Description modified (diff)

comment:3 Changed at 2013-08-19T18:20:06Z by markberger

Is there anything preventing this ticket from landing in 1.11? I would like to see this committed to trunk and I'm more than willing to help.

comment:4 Changed at 2013-08-19T18:26:34Z by tarcieri

It's not completely finished yet. If you take a look at it you'll see that the forms at the bottom are not rendering correctly. They need to be converted to a style similar to the welcome page

comment:5 Changed at 2013-08-30T14:45:06Z by markberger

I opened a ​pull request on ​Tony's pull request to fix the forms.

The allmydata.test.test_sftp unit test is broken on my branch but I believe it is fixed when the branch is rebased to trunk.

Last edited at 2013-08-30T14:47:09Z by markberger (previous) (diff)

comment:6 Changed at 2013-08-30T14:52:50Z by markberger

  • Milestone changed from soon to 1.11.0

Now that the forms are fixed, I'm hoping we can get this into 1.11.

comment:7 Changed at 2013-08-30T14:58:51Z by daira

  • Keywords review-needed added
  • Owner tarcieri deleted

comment:8 Changed at 2013-09-10T00:39:08Z by tarcieri

I updated my branch with markberger's contributions. This should be mergeable now.

comment:9 Changed at 2013-09-16T23:50:21Z by markberger

I reviewed everything Tony and Leif wrote for this patch and it looks good. Once someone reviews ​my part of the patch, this can be merged (it should take less than five minutes).

comment:10 Changed at 2013-09-16T23:58:40Z by tarcieri

Woohoo!

comment:11 Changed at 2013-09-17T15:37:47Z by zooko

  • Keywords reviewed added; review-needed removed

I reviewed the patch that markberger linked to in comment:9: ​https://github.com/tarcieri/tahoe-lafs/commit/dba982d0dfeaa42d54acd5298e3bc11cbc0bc00f#commitcomment-4112706

comment:12 Changed at 2013-12-01T12:11:51Z by daira

  • Keywords reviewed removed
  • Owner set to daira
  • Status changed from new to assigned

I will review the latest rebase on ​https://github.com/tahoe-lafs/tahoe-lafs/pull/32.

comment:13 Changed at 2014-07-29T12:52:54Z by daira

Well, I appear to have dropped the ball on review of this one, sorry.

comment:14 Changed at 2014-09-02T16:36:32Z by warner

  • Owner changed from daira to warner
  • Status changed from assigned to new

comment:15 Changed at 2014-09-02T18:15:00Z by warner

  • Status changed from new to assigned

I'll review and land this

comment:16 Changed at 2014-09-02T21:52:10Z by Brian Warner <warner@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In c4da6c91a79794d2af2a7b36a07785a823d70a46/trunk:

Merge branch tarcieri/redesigned-directory-page

Closes ticket:1966 (trac)
Closes tahoe-lafs/tahoe-lafs#32 (github PR)

Note: See TracTickets for help on using tickets.