Context Navigation

test_problem_layout_ticket_1128 in test_upload.py incorrectly sets up the test scenario

Reported by:	markberger	Owned by:	warner
Priority:	normal	Milestone:	1.10.1
Component:	dev-infrastructure	Version:	1.10.0
Keywords:	reviewed	Cc:
Launchpad Bug:

Description

Currently shares on server 0 are removed by this:

    storedir = self.get_serverdir(0)
    # remove the storedir, wiping out any existing shares
    shutil.rmtree(storedir)
    # create an empty storedir to replace the one we just removed
    os.mkdir(storedir)

However, while this deletes the shares, the remaining space on server 0 is set to 0, and therefore it will refuse any new shares even if the placement algorithm is correct.

Change History (9)

comment:1 Changed at 2013-06-24T20:52:47Z by markberger

Keywords review-needed added

Daira was able to show me how to delete the shares from the server without setting its remaining size to be 0. This pull request fixes the issue: https://github.com/tahoe-lafs/tahoe-lafs/pull/50

comment:2 Changed at 2013-06-25T23:59:49Z by daira

I'm not sure whether the problem is setting remaining space to 0, or the incoming directory being missing, or whether one causes the other. Anyway, these changes look fine, but we'll wait until we rebase your 1382 branch before committing them to trunk.

comment:3 Changed at 2013-08-28T16:00:42Z by zooko

Milestone changed from undecided to 1.11.0

comment:4 Changed at 2014-03-21T18:46:30Z by remyroy

Was this pull request already reviewed by daira?

comment:5 Changed at 2014-03-25T02:47:24Z by daira

Keywords reviewed added; review-needed removed

Yes, this was reviewed on the pull request.

comment:6 Changed at 2014-09-02T17:49:37Z by nejucomo

As the branchname indicates, this is related to #1128. That ticket is marked as a duplicate of #1130.

comment:7 Changed at 2014-09-02T18:22:52Z by warner

Owner changed from markberger to warner
Status changed from new to assigned

I will land this. The test is marked 'TODO', and it will probably continue to fail. But with this change it might actually start passing when the shares-of-happiness #1382 cluster lands.

comment:8 Changed at 2014-09-03T01:52:49Z by Brian Warner <warner@…>

Resolution set to fixed
Status changed from assigned to closed

In 3cfbe1cfc0c0c845e4cef66e5e69fd0b445054cf/trunk:

Merge branch markberger/ticket-2008

This changes test_upload.py to delete-all-shares more gently, leaving
the 'incoming' directory in place, which should help the rest of the
test pass.

Closes tahoe-lafs/tahoe-lafs#50 (github PR)
Closes ticket:2008 (trac)

comment:9 Changed at 2014-09-03T01:59:01Z by Brian Warner <warner@…>