Opened at 2013-08-07T16:16:56Z

Closed at 2014-05-05T14:46:41Z

Last modified at 2014-05-05T18:45:25Z

#2048 closed defect (fixed)

allmydata.test.test_cli.Cp.test_copy_using_filecap is really slow due to a test bug

Reported by: daira Owned by: daira
Priority: normal Milestone: 1.10.1
Component: code Version: 1.10.0
Keywords: test performance Cc:
Launchpad Bug:

Description (last modified by daira)

The fix for #1805 (595d611c9b4b29c8/trunk) added the following code in allmydata.test.test_cli.Cp.test_copy_using_filecap: 

        #  cp --verbose filename3 dircap:test_file
        d.addCallback(lambda ign:
                      self.do_cli("cp", "--verbose", '--recursive', self.basedir, self.dircap))
        def _test_for_wrong_indices((rc, out, err)):
            self.failUnless('examining 1 of 1\n' in err)
        d.addCallback(_test_for_wrong_indices)

The tahoe cp command is copying the whole basedir of the test recursively into the self.dircap directory, which is definitely not what we want, and is really slow.

Change History (14)

comment:1 Changed at 2013-08-07T16:18:08Z by daira

  • Description modified (diff)

comment:2 Changed at 2013-08-11T13:13:31Z by daira

  • Keywords review-needed added
  • Owner set to markberger

See branch ​https://github.com/tahoe-lafs/tahoe-lafs/commits/2048-test-copy-using-filecap.

comment:3 Changed at 2014-03-27T22:17:07Z by daira

I just pushed a rebase to current trunk on that branch.

comment:4 Changed at 2014-03-27T22:17:33Z by daira

  • Owner changed from markberger to remyroy

comment:5 Changed at 2014-03-27T22:19:05Z by daira

  • Milestone changed from soon to 1.11.0

comment:6 Changed at 2014-05-05T14:06:45Z by remyroy

  • Keywords reviewed added; review-needed removed
  • Owner changed from remyroy to daira

I just completed the review of ​https://github.com/tahoe-lafs/tahoe-lafs/commits/2048-test-copy-using-filecap .

Everything is fine. Good job.

Transferring this ticket back to daira for merge in trunk.

comment:7 Changed at 2014-05-05T14:30:31Z by daira

  • Status changed from new to assigned

Thanks, will commit now.

comment:8 Changed at 2014-05-05T14:46:41Z by Daira Hopwood <daira@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 20b26f773b6c910a8da4122730f58b86509d611b/trunk:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@…>

comment:9 Changed at 2014-05-05T14:47:18Z by Daira Hopwood <daira@…>

In 20b26f773b6c910a8da4122730f58b86509d611b/trunk:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@…>

comment:10 Changed at 2014-05-05T14:47:49Z by daira

  • Keywords reviewed removed

comment:11 Changed at 2014-05-05T18:32:37Z by Daira Hopwood <daira@…>

In 20b26f773b6c910a8da4122730f58b86509d611b/trunk:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@…>

comment:12 Changed at 2014-05-05T18:33:37Z by Daira Hopwood <daira@…>

In 20b26f773b6c910a8da4122730f58b86509d611b/trunk:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@…>

comment:13 Changed at 2014-05-05T18:43:32Z by Daira Hopwood <daira@…>

In 20b26f773b6c910a8da4122730f58b86509d611b/trunk:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@…>

comment:14 Changed at 2014-05-05T18:45:25Z by Daira Hopwood <daira@…>

In 20b26f773b6c910a8da4122730f58b86509d611b/trunk:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@…>

Note: See TracTickets for help on using tickets.