#205 closed defect (fixed)

checker for mutable files: make "check" button on wui work

Reported by: zooko Owned by: warner
Priority: major Milestone: 1.3.0
Component: code-mutable Version: 0.7.0
Keywords: Cc:
Launchpad Bug:


Currently if you click the "check" button on a mutable file it raises an exception saying it doesn't know how to check that kind of file.

Change History (14)

comment:1 Changed at 2007-11-13T18:17:10Z by zooko

  • Milestone changed from 0.7.0 to 0.7.1
  • Version changed from 0.6.1 to 0.7.0

comment:2 Changed at 2007-11-13T18:36:17Z by zooko

  • Milestone changed from 0.7.1 to 1.0

I don't think we plan to do this before the end of December, so I'm putting it in Milestone 1.0.

comment:3 Changed at 2008-01-05T03:51:51Z by warner

  • Milestone changed from 1.0 to 0.8.0

comment:4 Changed at 2008-01-09T01:09:44Z by warner

  • Milestone changed from 0.8.0 (Allmydata 3.0 Beta) to 0.10.0

comment:5 Changed at 2008-02-08T03:46:43Z by warner

Zooko and I came up with a refactoring of the mutable.Retrieve class that would make it fairly easy to re-use the same code between Retrieve, Checker, and Verifier.

The bulk of the code is in a new class, tenatively named mutable.CiphertextRetrieval. This class is given a verifier capability, a peer getter (i.e. client.get_permuted_peers, and a value of epsilon (which might be 'infinity'). It might also get some indication of how much data should be fetched: as little as possible, or full verification of all outstanding shares. Likewise it might need to know if we want to get ciphertext from all available versions, or just the most recent. This class returns a MutableRetrievalResults instance.

This CiphertextRetrieval class then does the queries and readvs, and populates the results instance with several things:

  • timing information (like what upload.UploadResults gets
  • version_map: dict mapping (seqnum, R, encodingparams) to a set of (shnum, peerid, good/bad) tuples. This is most useful for the checker.
  • retrieveable_versions: a set of (seqnum, R, encodingparams) tuples, one for each version that appears to be retrievable
  • ciphertext_map: dict mapping (seqnum, R, encodingparams) to a (salt/IV, ciphertext_string) tuple.

The MutableFileNode would then be responsible for doing two things with the MutableRetrievalResults object:

  • extract the most recent version, by sorting ciphertext_map and taking the value associated with the last key
  • decrypting that with the readkey and the salt/IV.

The checker would be more interested in the version_map: the most useful checker results would be "version 34 is retrievable, and there are 9 out of 10 shares available".

A more sophisticated app (some variant of MutableFileNode could expose multiple versions to the application, instead of only picking the most recent one. Single-version apps might benefit from knowing that there are validly-signed shares of a newer version out there, even if that version has too few shares to be retrieved. (i.e. version_map has a key which is greater than the highest key of retrieveable_versions).

There are lots of intermediate points here. A really basic checker would just care if any version is retrievable. A full verifier would want to download all shares and check all signatures (signalling errors along the way). An appropriate balance between bandwidth+CPU versus results will lie somewhere in between.

comment:6 Changed at 2008-03-10T20:34:40Z by warner

  • Summary changed from checker for mutable files to checker for mutable files / refactor Retrieve to show multiple versions

comment:7 Changed at 2008-04-24T23:27:03Z by warner

  • Component changed from code to code-mutable
  • Owner somebody deleted

comment:8 Changed at 2008-05-29T22:27:38Z by warner

  • Milestone changed from 1.1.0 to 1.2.0

comment:9 Changed at 2008-06-19T22:53:00Z by warner

The mutable file code has been refactored to make multiple versions visible to the application layer. It has not been modified to separate ciphertext retrieval from plaintext retrieval.

comment:10 Changed at 2008-07-14T22:35:53Z by warner

  • Owner set to warner
  • Status changed from new to assigned
  • Summary changed from checker for mutable files / refactor Retrieve to show multiple versions to checker for mutable files: make "check" button on wui work

however, there is new code in source:src/allmydata/mutable/checker.py which implements the Verifier in a different way. The regular download code is designed to do as little work as possible, while the verifier wants to download (and verify) as much data as possible. So the two goals are not particularly well aligned, making it more appropriate to use two separate classes.

The remaining pieces of this ticket are to make the 'check' button on the webapi work properly. This either means nailing down what the return value from filenode.check() ought to be, or incorporating the mutable checker results into the Checker service's results table.

comment:11 Changed at 2008-07-14T23:09:12Z by warner

My current plan:

  • filenode.check() should return an object that understands ICheckerResults, and stores a small amount of data into the checker service (indexed by verify-cap)
  • the webapi has a POST t=check (and t=verify) operation which creates a filenode, invokes a check/verify, and uses results.to_html() to render the output.
    • This output will contain detailed information about the file: which shares were where, request latency information, maybe pretty pictures showing the distribution of servers and shares around the peer-selection ring. If the check triggered a repair, the results of the repair operation will be included on this page.
    • The webapi operation will accept a when_done= argument, in which case the detailed output is ignored.
    • It will also accept a 'back_to=' argument, which will add a link to the resulting page (to bring the user back to the parent directory).
  • we add ImmutableVerifierNode and MutableVerifierNode, which have check/verify/repair methods.
  • the client.create_node_from_uri() will be updated to create verifier nodes from verifier caps
  • the Checker service will lose its check()/verify() methods, and will become merely a repository for checker results

comment:12 Changed at 2008-07-16T04:03:46Z by warner

we've now got ICheckerResults, and the Checker service is gone, and we've removed results-storage altogether. The new scheme is to invoke the .check() method on a filenode or dirnode, instead of passing a URI to the Checker.

comment:13 Changed at 2008-09-03T01:19:26Z by warner

  • Milestone changed from 1.4.0 to 1.3.0

comment:14 Changed at 2008-09-18T05:19:22Z by warner

  • Resolution set to fixed
  • Status changed from assigned to closed

Ok, I'm now happy with the way the checker is driven. The web pages look good.

Note: See TracTickets for help on using tickets.