I2P client endpoint parameter concatenator

[dawuud]

note: this ticket description is inspired by str4d's commit here: ​https://github.com/david415/tahoe-lafs/commit/21cc326f6bd8aedbb3d9478c8591234c3c0b08a0

As discussed on IRC with str4d... the client side of the native I2P integration for Tahoe-LAFS would need a way to pass the I2P endpoint object some private client parameters. str4d proposes a solution: transform the endpoint string before passing it to clientFromString.

That very transpormation should take place in Tahoe-LAFS and it should append the user specified parameters to the Twisted endpoint string.

Clients may need to extend client side Twisted endpoint strings. This seems like a reasonable feature for several Twisted endpoint types.

tcp:example.org:1337:timeout=60
ssl:example.org:443:caCertsDir=/etc/ssl/certs
i2p:longstring.b32.i2p:tunnelNick=tahoe:inport=10000

These should be set in tahoe.cfg like this:

[node]
clientEndpointParams = tcp:timeout=60,ssl:caCertsDir=/etc/ssl/certs,i2p:tunnelNick=tahoe:inport=10000

str4d wrote:

Tahoe parses, keeps an internal map, applies the relevant params to a client endpoint string before connecting

[str4d]

Removed the client endpoint string whitelisting comments from the description, I have opened a Twisted ticket for that:

​https://twistedmatrix.com/trac/ticket/7632

[str4d]

I opened a ticket with Twisted for this functionality:

​https://twistedmatrix.com/trac/ticket/7634

If we can get an API method there, that would be best. Otherwise, we will need to implement it.

[dawuud]

note: we no longer need this ticket because foolscap has a new transport plugin system.