#2321 closed defect (wontfix)
when built from a github download zipfile, tahoe --version prints "allmydata-tahoe: unknown [unknown: unknown]"
| Reported by: | daira | Owned by: | sly |
|---|---|---|---|
| Priority: | minor | Milestone: | undecided |
| Component: | packaging | Version: | 1.10.0 |
| Keywords: | version error github | Cc: | sly |
| Launchpad Bug: |
Description (last modified by daira)
In 2320#comment:3 sly wrote:
After [it has] finally been built, on a command "bin\tahoe --version" it outputs:
allmydata-tahoe: unknown [unknown: unknown] foolscap: 0.7.0 pycryptopp: 0.6.0.1206569328141510525648634803928199668821045408958 zfec: 1.4.22 Twisted: 11.0.0 Nevow: 0.10.0 zope.interface: unknown python: 2.7.8 platform: Windows-7-6.1.7601-SP1 pyOpenSSL: 0.13.1 simplejson: 3.6.4 pycrypto: 2.4.1 pyasn1: 0.1.7 mock: 1.0.1 setuptools: 0.6c16dev5
Is it ok? quickstart guide says that it should output some "the right version number".
Change History (7)
comment:1 Changed at 2014-10-16T22:41:20Z by daira
- Cc sly added
- Owner set to sly
comment:2 Changed at 2014-10-16T22:52:33Z by daira
- Description modified (diff)
- Keywords github added
- Resolution set to wontfix
- Status changed from new to closed
Ah, never mind, I can reproduce it on my machine, using the zipfile downloaded from https://github.com/tahoe-lafs/tahoe-lafs/archive/master.zip.
The first line of tahoe --version-and-path also gives an unknown version with the correct path (e.g. allmydata-tahoe: unknown [unknown: unknown] ([...]/tahoe-lafs-master/src)). src/allmydata/_version.py does not exist.
It appears that the github download .zip does not contain the .git directory, so I don't think this is fixable. We'll just have to avoid telling people to use that download method (or take into account that they'll get a Tahoe build that doesn't know its version).
comment:3 Changed at 2014-10-16T22:54:27Z by daira
- Component changed from code to packaging
- Priority changed from normal to minor
- Summary changed from bin\tahoe --version prints "allmydata-tahoe: unknown [unknown: unknown]" to when built from a github download zipfile, tahoe --version prints "allmydata-tahoe: unknown [unknown: unknown]"
comment:4 Changed at 2014-10-17T01:24:38Z by zooko
Doesn't this mean we need to fix our building of .zip files to include the .git dir in them, or else stop building .zip files? Or what?
comment:5 Changed at 2014-10-17T01:35:46Z by daira
This doesn't affect the .zip files we build as sdists; only the ones created by the "Download ZIP" button on github.
comment:6 follow-up: ↓ 7 Changed at 2014-10-17T01:45:38Z by daira
Hmm, I was going to link to a snapshot zipfile in https://tahoe-lafs.org/source/tahoe-lafs/snapshots/ to demonstrate that it doesn't have this problem, but that directory doesn't contain any snapshots built after June 26 2013.
comment:7 in reply to: ↑ 6 Changed at 2014-10-17T02:03:31Z by daira
Replying to daira:
Hmm, I was going to link to a snapshot zipfile in https://tahoe-lafs.org/source/tahoe-lafs/snapshots/ to demonstrate that it doesn't have this problem, but that directory doesn't contain any snapshots built after June 26 2013.
... possibly due to #2315.
No, that's unexpected. Please paste the output of the following commands: