Opened at 2014-11-21T00:33:11Z

Closed at 2014-11-22T00:06:27Z

Last modified at 2014-11-22T00:06:50Z

#2340 closed defect (fixed)

poor error reporting when "git describe" fails during setup.py update_version

Reported by: cipherpunks Owned by: daira
Priority: normal Milestone: 1.10.1
Component: packaging Version: 1.10.0
Keywords: packaging error git easy Cc:
Launchpad Bug:

Description

Suppose we are building from a copy of a git repo. If git describe fails (for example because git is not actually installed), the resulting tahoe will not know its version, but there will be no errors or warnings during the build. If tahoe does not know its version then some tests will fail when trying to import allmydata._version.

Change History (1)

comment:1 Changed at 2014-11-22T00:06:27Z by daira

  • Milestone changed from undecided to 1.11.0
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [4421e8a84b1fe81ee7ed32ee2d07eae00b629aa2/trunk]. The update_version step now prints a warning when it cannot find the version. Specifically, if there is a .git directory then it tries to update the version; if that fails or there was neither a .git directory nor a _version.py file, then it prints: 

********************************************************************
Warning: no version information found. This may cause tests to fail. 
********************************************************************
Last edited at 2014-11-22T00:06:50Z by daira (previous) (diff)
Note: See TracTickets for help on using tickets.