Opened at 2015-06-01T22:33:28Z
Closed at 2015-06-11T16:34:37Z
#2442 closed defect (fixed)
implement flat hierarchy file representation scheme for magicfolder
| Reported by: | dawuud | Owned by: | daira |
|---|---|---|---|
| Priority: | normal | Milestone: | undecided |
| Component: | code-frontend-magic-folder | Version: | 1.10.0 |
| Keywords: | otf-magic-folder-objective4 | Cc: | |
| Launchpad Bug: |
Description (last modified by daira)
Daira and I were just discussing using an escape character to represent directory "/"... we're thinking to use "@" as the escape character. It should work the same way bash backslashes work... if the user specified an @ character in the directory name then we escape it by specifying two of them @@
Change History (6)
comment:1 Changed at 2015-06-01T22:58:25Z by dawuud
- Description modified (diff)
comment:2 Changed at 2015-06-02T00:16:16Z by dawuud
comment:3 Changed at 2015-06-03T02:00:32Z by daira
We changed the escape for "/" to "@_", since escaping it as a single "@" would be ambiguous. (Consider "foo/@/bar" and "foo@@bar" which both escape to "foo@@@@bar" in the previous scheme.)
comment:4 Changed at 2015-06-03T02:01:42Z by daira
- Component changed from unknown to code-frontend-magic-folder
- Description modified (diff)
- Keywords otf-magic-folder-objective4 added
comment:5 Changed at 2015-06-04T23:26:50Z by dawuud
This latest commit causes the uploader to use our magicpath encoding for uploaded files... and i also upload a blank file for each directory ending in "@_".
https://github.com/david415/tahoe-lafs/tree/2442.flat-hierarchy-uploader.1
https://github.com/david415/tahoe-lafs/commit/9e0cf6486fc8c7a1d6a0e979507b952d0b40e398
Please review.
comment:6 Changed at 2015-06-11T16:34:37Z by daira
- Resolution set to fixed
- Status changed from new to closed
Fixed on the 2438.otf-objective-4.2 branch.
ok my rough draft code for this is here: https://github.com/david415/tahoe-lafs/tree/magic-path-encoding.1
should i close this ticket as a duplicate? i noticed Daira commented about this task in that other ticket here: https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2438