Opened at 2015-06-11T22:12:23Z
Closed at 2015-12-21T22:19:50Z
#2449 closed defect (fixed)
Magic Folder: ensure we test that remote Tahoe DMDs are scanned on startup
| Reported by: | dawuud | Owned by: | daira |
|---|---|---|---|
| Priority: | normal | Milestone: | undecided |
| Component: | code-frontend-magic-folder | Version: | 1.10.0 |
| Keywords: | blocks-magic-folder-merge test-needed | Cc: | |
| Launchpad Bug: |
Description
Magic Folder should scan the remote Tahoe uploader directory upon startup so that Magic Folder will function correctly for the edge cases where the magic folder db is destroyed or inconsistent.
Change History (12)
comment:1 Changed at 2015-07-07T18:43:32Z by daira
- Component changed from unknown to code-frontend-magic-folder
- Keywords otf-magic-folder-objective4 added; magic folder removed
comment:2 Changed at 2015-07-09T21:19:10Z by dawuud
comment:3 Changed at 2015-07-14T11:17:15Z by dawuud
ok i got the test_persistence test to pass: https://github.com/david415/tahoe-lafs/tree/1710.local-deletion-water-dragon.1.test-alice-and-bob.1
perhaps this ticket can be closed after code review
comment:4 Changed at 2015-07-23T15:13:41Z by daira
- Keywords review-needed added
- Status changed from new to assigned
comment:5 Changed at 2015-11-04T01:22:54Z by daira
See also #2553.
comment:6 Changed at 2015-11-04T10:15:13Z by dawuud
fixed in this simple commit; only scan our own dmd upon startup:
https://github.com/david415/tahoe-lafs/commits/2551.remote-conflict-detection.4 https://github.com/david415/tahoe-lafs/commit/e926c4cf2b8004c3d56281e9755bd0c44d663a73
However... we don't have a test for this.
comment:7 Changed at 2015-12-03T19:27:01Z by daira
- Keywords blocks-magic-folder-merge test-needed added; otf-magic-folder-objective4 review-needed removed
- Summary changed from Magic Folder: scan remote Tahoe upload directory upon startup to Magic Folder: ensure we test that remote Tahoe DMDs are scanned on startup
comment:8 Changed at 2015-12-04T12:48:32Z by dawuud
- Status changed from assigned to new
comment:9 Changed at 2015-12-09T11:35:48Z by dawuud
Dear Daira,
That last commit is relevant to this ticket because it adds unit tests for testing the behavior we want to see; that our remote DMD is scanned on startup.
https://github.com/david415/tahoe-lafs/commit/d223d02ac8c9360209580c1dfb686aef63d01477
please review thanks
comment:10 Changed at 2015-12-14T22:10:51Z by daira
- Status changed from new to assigned
comment:11 Changed at 2015-12-21T21:41:54Z by daira
Pushed that commit to 2438.magic-folder-stable.5.wip .
comment:12 Changed at 2015-12-21T22:19:50Z by daira
- Resolution set to fixed
- Status changed from assigned to closed
Pushed to 2438.magic-folder-stable.5 .
here in my dev branch i've got the remote scan triggered on startup:
https://github.com/david415/tahoe-lafs/tree/1710.local-deletion-water-dragon.1.test-alice-and-bob.1.fix_persistence_test.1
the only unit test so far that tests startup code path is test_persistence... and currently that test is broken. i could use some help fixing it.