Opened at 2015-09-02T16:00:10Z

Closed at 2015-12-21T22:21:39Z

#2495 closed defect (fixed)

'tahoe magic-folder join' can do the wrong thing if tahoe.cfg is not newline-terminated

Reported by: daira Owned by: daira
Priority: normal Milestone: undecided
Component: code-frontend-magic-folder Version: unknown
Keywords: blocks-magic-folder-merge test-needed Cc:
Launchpad Bug:

Description

​https://github.com/tahoe-lafs/tahoe-lafs/commit/847e8e99e9d1ce59f0f0f7e0d95be51ef4ec82d3#commitcomment-13027082

Change History (7)

comment:1 Changed at 2015-12-03T18:06:13Z by daira

We should use the SafeConfigParser API.

comment:2 Changed at 2015-12-03T18:07:09Z by daira

  • Keywords blocks-magic-folder-merge added; otf-magic-folder-objective4 removed

comment:3 Changed at 2015-12-04T11:16:25Z by dawuud

  • Owner changed from david415 to daira

ok... i've completed this task: ​https://github.com/david415/tahoe-lafs/tree/2495.use-config-parser.0

needs review.

comment:4 Changed at 2015-12-04T20:16:03Z by daira

  • Status changed from new to assigned

Reviewing.

comment:5 Changed at 2015-12-04T20:28:10Z by daira

  • Owner changed from daira to dawuud
  • Status changed from assigned to new

Reviewed, comments at ​https://github.com/david415/tahoe-lafs/commit/63eec3bd871124a798b401ef0fc1ccc173299d60.

comment:6 Changed at 2015-12-07T21:51:16Z by dawuud

  • Owner changed from dawuud to daira

fixed here: ​https://github.com/tahoe-lafs/tahoe-lafs/pull/208

comment:7 Changed at 2015-12-21T22:21:39Z by daira

  • Resolution set to fixed
  • Status changed from new to closed

Pushed to 2438.magic-folder-stable.5 .

Note: See TracTickets for help on using tickets.