#2518 closed defect (fixed)

Magic Folder tests: ascii decode error with Twisted 15.0.0

Reported by: zooko Owned by: daira
Priority: normal Milestone: undecided
Component: code-frontend-magic-folder Version: 1.10.1
Keywords: magic-folder tests Twisted unicode Cc:
Launchpad Bug:

Description

Magic Folder 'client-0' uploader: stop
'magic_folder.uploader.dirs_monitored' += -1
Traceback (most recent call last):
  File "/home/zooko/playground/tahoe/tahoe-lafs/src/allmydata/test/test_magic_folder.py", line 55, in _wait_until_started
    return self.magicfolder.ready()
  File "/home/zooko/playground/tahoe/tahoe-lafs/src/allmydata/frontends/magic_folder.py", line 80, in ready
    d = self.uploader.start_scanning()
  File "/home/zooko/playground/tahoe/tahoe-lafs/src/allmydata/frontends/magic_folder.py", line 226, in start_scanning
    d = self._scan(u"")
  File "/home/zooko/playground/tahoe/tahoe-lafs/src/allmydata/frontends/magic_folder.py", line 238, in _scan
    fp = self._get_filepath(reldir_u)
  File "/home/zooko/playground/tahoe/tahoe-lafs/src/allmydata/frontends/magic_folder.py", line 123, in _get_filepath
    return extend_filepath(self._local_filepath, relpath_u.split(u"/"))
  File "/home/zooko/playground/tahoe/tahoe-lafs/src/allmydata/util/encodingutil.py", line 265, in extend_filepath
    fp = fp.child(segment)
  File "/usr/local/lib/python2.7/dist-packages/Twisted-15.0.0-py2.7-linux-x86_64.egg/twisted/python/filepath.py", line 696, in child
    newpath = abspath(joinpath(self.path, norm))
  File "/usr/lib/python2.7/posixpath.py", line 80, in join
    path += '/' + b
exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xc4 in position 127: ordinal not in range(128)
<daira> zooko: force Twisted to be >= 15.2.0
<daira> that'll work around the problem

Change History (3)

comment:1 Changed at 2015-10-06T14:42:38Z by daira

  • Component changed from unknown to code-frontend-magic-folder
  • Keywords magic-folder tests Twisted unicode added
  • Status changed from new to assigned
  • Summary changed from ascii decode error with Twisted 15.0.0 to Magic Folder tests: ascii decode error with Twisted 15.0.0

comment:2 Changed at 2015-10-06T14:50:03Z by zooko

Upgrading to Twisted trunk (which identifies itself as "Twisted 15.4.0") fixed it.

comment:3 Changed at 2015-10-28T23:35:03Z by daira

  • Resolution set to fixed
  • Status changed from assigned to closed

This is fixed on the 2438.magic-folder-stable.5 branch, by declaring a dependency on Twisted >= 15.2.0.

Note: See TracTickets for help on using tickets.