Opened at 2015-10-27T10:04:56Z
Closed at 2015-12-08T15:52:34Z
#2554 closed defect (fixed)
Magic-Folder: exclude a file only once
| Reported by: | dawuud | Owned by: | daira |
|---|---|---|---|
| Priority: | normal | Milestone: | undecided |
| Component: | code-frontend-magic-folder | Version: | 1.10.1 |
| Keywords: | magic-folder | Cc: | |
| Launchpad Bug: |
Description
right now if a file is excluded from being downloaded... we apparently exclude this file every remote scan turn; thus incrementing the excluded count each turn. This behavior seems wrong. Should we track an excluded list to avoid recounting olde exclusions?
Change History (5)
comment:1 Changed at 2015-10-27T11:38:33Z by daira
comment:2 Changed at 2015-12-07T15:57:29Z by daira
- Owner changed from daira to dawuud
comment:3 Changed at 2015-12-07T20:58:23Z by dawuud
fixed here. i removed the excluded stat... it's not needed: https://github.com/tahoe-lafs/tahoe-lafs/pull/209
please review and or merge and close
comment:4 Changed at 2015-12-07T20:58:35Z by dawuud
- Owner changed from dawuud to daira
comment:5 Changed at 2015-12-08T15:52:34Z by daira
- Resolution set to fixed
- Status changed from new to closed
Merged into 2438.magic-folder-stable.5.
Note: See
TracTickets for help on using
tickets.
An excluded count that increments every scan isn't useful for reliable tests or monitoring, so let's remove it (replacing its use in the tests with something that is reliable -- not necessarily a count).