Opened at 2015-10-28T02:47:13Z

Closed at 2015-12-01T18:34:00Z

Last modified at 2016-07-21T21:32:36Z

#2556 closed defect (fixed)

node creation commands include \\?\ in the output on Windows

Reported by: daira Owned by: Daira Hopwood <daira@…>
Priority: normal Milestone: 1.11.0
Component: code-frontend-cli Version: 1.10.1
Keywords: windows unicode usability aesthetics review-needed Cc:
Launchpad Bug:

Description

E.g.: 

D:\tahoe\git\tahoe-magic>bin\tahoe create-introducer \grid\intro
Introducer created in '\\?\D:\grid\intro'

D:\tahoe\git\tahoe-magic>bin\tahoe create-node \grid\server
Node created in '\\?\D:\grid\server'

They should be using quote_local_unicode_path.

Change History (9)

comment:1 Changed at 2015-10-28T02:59:47Z by daira

  • Keywords test-needed added

I have a fix, but no test yet.

comment:2 Changed at 2015-10-28T03:01:58Z by daira

While we're at it, create-stats-gatherer and create-key-generator should print a similar message rather than being silent on success.

comment:3 Changed at 2015-10-28T13:54:57Z by daira

Fixed and tested on the 2438.magic-folder-stable.5 branch, but this is not on master yet.

comment:4 Changed at 2015-10-28T13:55:24Z by daira

  • Milestone changed from undecided to 1.10.3
  • Status changed from new to assigned

comment:5 Changed at 2015-12-01T18:02:53Z by daira

  • Keywords review-needed added; test-needed removed
  • Owner daira deleted
  • Status changed from assigned to new

Please review ​https://github.com/tahoe-lafs/tahoe-lafs/pull/203.

comment:6 Changed at 2015-12-01T18:34:00Z by Daira Hopwood <daira@…>

  • Owner set to Daira Hopwood <daira@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 02d96b970e3b0df5fd4629d8ec54ee5ac96818a5/trunk:

Quote local paths correctly in the output of node creation commands. fixes ticket:2556

Signed-off-by: Daira Hopwood <daira@…>

comment:7 Changed at 2015-12-01T18:34:01Z by Daira Hopwood <daira@…>

In 8ce7e2430c4b956481715e8300218b5963ef8e30/trunk:

Add test for 'tahoe create-node/client/introducer' output. closes ticket:2556

Signed-off-by: Daira Hopwood <daira@…>

comment:8 Changed at 2016-03-22T05:03:36Z by warner

  • Milestone changed from 1.10.3 to 1.11.0

Milestone renamed

comment:9 Changed at 2016-07-21T21:32:36Z by Brian Warner <warner@…>

In f77c593/trunk:

Add test for 'tahoe create-node/client/introducer' output. closes ticket:2556

Signed-off-by: Daira Hopwood <daira@…>

Note: See TracTickets for help on using tickets.