Magic Folder: update Operational Statistics page to take account of renames

[daira]

Drop-Uploader

Local Directories Monitored: 0 directories
Files Uploaded: 0 files
File Changes Queued: 0 files
Failed Uploads: 0 files

Raw Stats:

{'counters': {'magic_folder.uploader.directories_created': 1,
              'magic_folder.uploader.dirs_monitored': 1,
              'magic_folder.uploader.objects_not_uploaded': 3,
              'magic_folder.uploader.objects_queued': -1,
              'magic_folder.uploader.objects_succeeded': 4,
              'mutable.bytes_published': 385,
              'mutable.bytes_retrieved': 36194,
              'mutable.files_published': 1,
              'mutable.files_retrieved': 83,
              'uploader.bytes_uploaded': 0,
              'uploader.files_uploaded': 1},
[...]

Besides the name of the section being wrong, the counts are shown as zeroes in the "Drop-Uploader" section because they are looking at the wrong raw counter names. (An underlying design flaw is that querying a non-existent counter gives 0, rather than an error.)

[daira]

'magic_folder.uploader.objects_queued': -1 probably also indicates a bug somewhere.

(This is not part of this ticket; see #2731.)

[dawuud]

We improved the unit tests here in this dev branch ​https://github.com/david415/tahoe-lafs/tree/2709.fix-magic-folder-stats.1

[daira]

Fixed on 2438.magic-folder-stable.12.

[Brian Warner <warner@…>]

In dd0597f/trunk:

Work in progress to fix incorrect statistics output for Magic Folder. refs ticket:2709