Opened at 2016-02-23T16:19:34Z
Closed at 2016-10-19T20:15:07Z
#2737 closed defect (fixed)
Magic Folder on Windows: test_alice_bob fails because the uploader is processing files we've downloaded
| Reported by: | daira | Owned by: | meejah |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.12.0 |
| Component: | code-frontend-magic-folder | Version: | n/a |
| Keywords: | tests windows magic-folder | Cc: | |
| Launchpad Bug: |
Description
When the downloader writes a file using _write_downloaded_file, the uploader is supposed to ignore any associated filesystem notifications. On both Linux and Windows, notifications for the .tmp file are correctly ignored. On Linux, the IN_CREATE notification for the downloaded file itself is also ignored, because it's a creation of a non-directory. (_write_downloaded_file works by initially creating a hardlink at the new path, which does not cause an IN_CLOSE_WRITE event.)
On Windows, the ReplaceFileW call causes a "modify, attrib" event which does (incorrectly) cause the downloaded file to be processed.
Change History (4)
comment:1 Changed at 2016-03-22T05:02:52Z by warner
- Milestone changed from 1.11.0 to 1.12.0
comment:2 Changed at 2016-09-06T17:00:41Z by meejah
All the tests pass now, but this should be re-tested to ensure we're not doing 2x processing on windows
comment:3 Changed at 2016-09-06T17:00:53Z by meejah
- Owner changed from daira to meejah
comment:4 Changed at 2016-10-19T20:15:07Z by meejah
- Resolution set to fixed
- Status changed from new to closed
We are not doubling the processing any longer (and I believe the tests cover this properly).
Milestone renamed