#2766 closed task (fixed)

remove unnecessary dependencies

Reported by: warner Owned by: GitHub <noreply@…>
Priority: normal Milestone: eventually
Component: packaging Version: 1.11.0
Keywords: review-needed Cc:
Launchpad Bug:

Description

Let's remove characteristic right now, it's a throwback to some old pyopenssl thing, and the only place it exists at all in our depenency graph is in tahoe's _auto_deps.py.

Let's remove the transitive dependencies: things we claim to depend upon but never import:

  • pyopenssl
  • service-identity
  • pyasn1-modules
  • pyasn1

Let's do a global s/simplejson/json/ and stop depending on the simplejson module. The json in stdlib should be enough. (This is a leftover from the days of python2.5(?) that didn't have stdlib json, but now we require py2.7).

We need to retain twisted[tls] instead of just twisted because pip lacks a resolver.

Not a part of this ticket:

  • #2098 : get zfec to remove dependency on pyutil/zbase32

Change History (4)

comment:1 Changed at 2016-04-04T05:29:27Z by warner

  • Owner changed from daira to warner
  • Status changed from new to assigned

I'm working on this. The simplejson change is a bit involved (a couple of dozen files, and some use the json symbol as method or variable names already), but I'm almost done.

comment:2 Changed at 2017-03-24T02:22:36Z by Brian Warner <warner@…>

In c1ed556/trunk:

Merge PR405: use stdlib "json" instead of simplejson

refs ticket:2766

comment:3 Changed at 2019-08-13T17:56:55Z by exarkun

  • Keywords review-needed added
  • Owner warner deleted
  • Status changed from assigned to new

comment:4 Changed at 2019-08-13T19:19:46Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 6d14a2d/trunk:

Merge pull request #642 from tahoe-lafs/2766.remove-unnecessary-dependencies

Remove declaration of some unnecessary dependencies.

Fixes: ticket:2766

Note: See TracTickets for help on using tickets.