#2806 closed defect (fixed)

test_magic_folder fails about 30%

Reported by: warner Owned by: daira
Priority: critical Milestone: 1.12.0
Component: code-frontend-magic-folder Version: 1.11.0
Keywords: Cc: dawuud
Launchpad Bug:


We're seeing the buildbot fail on test_magic_folder about 30% of the time, on the Ubuntu buildslave.

The specific test is test_magic_folder.MockTestAliceBob.test_alice_bob, on line 922, right after the call to Alice_to_write_file3, where it checks the object_downloaded count. It's expecting 7, and got 6.

Change History (5)

comment:1 Changed at 2016-08-15T21:47:53Z by meejah

I'm trying to determine if test_alice_bob actually covers any code not already covered by other test-cases -- but so far my most-consistent way to have this test fail is when running under coverage. So, I have not yet determined the answer to my question :/ but to "see it fail" your chances seem to be way higher running like coverage 'which trial' allmydata.test (those aren't backticks around "which trial", but they should be "because markdown markup").

comment:2 Changed at 2016-08-16T00:37:35Z by meejah

If we removed test_alice_bob entirely, we'd lose coverage on the following lines:

  • immutable/checker.py: 63,67,69
  • magicpath.py: 30
  • frontends/magic_folder.py: 792,793,990,991
  • web/status.py: 917

I'm trying to confirm if we "really" cover the _check_integrity lines or if those appear covered because of an error happening (i.e. test-failure).

comment:3 Changed at 2016-08-18T16:38:30Z by meejah

I have re-factored things and now test_alice_bob takes 1.5s which is pretty reasonable. See https://github.com/tahoe-lafs/tahoe-lafs/pull/313

comment:4 Changed at 2016-08-19T17:39:12Z by meejah

  • Resolution set to fixed
  • Status changed from new to closed

313 landed, so this can be closed. Right?

comment:5 Changed at 2016-08-19T23:59:47Z by warner

Yup.. thanks!

Note: See TracTickets for help on using tickets.