Opened at 2016-12-28T20:39:44Z
Closed at 2017-07-28T00:41:30Z
#2857 closed task (fixed)
stop using deprecated twisted.web.client.getPage
| Reported by: | warner | Owned by: | Brian Warner <warner@…> |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.13.0 |
| Component: | code | Version: | 1.12.0 |
| Keywords: | Cc: | ||
| Launchpad Bug: |
Description
Twisted-16.7.0 is coming soon, and it deprecates twisted.web.client.getPage (and client.HTTPClientFactory). We use these in some of the unit tests, to fetch one of the HTTP WAPI/WUI pages and make sure the contents look right.
We need to change these tests to use twisted.web.client.Agent instead, or a package named "treq", which is a Twisted flavor of the excellent (but blocking) requests library.
This was caught by the Deprecations buildbot, testing Tahoe against Twisted trunk: https://tahoe-lafs.org/buildbot-tahoe-lafs/builders/deprecations/builds/160/steps/upcoming-deprecations/logs/warnings
The Twisted deprecation ticket was https://twistedmatrix.com/trac/ticket/8960
Change History (2)
comment:1 Changed at 2017-07-13T00:34:41Z by warner
comment:2 Changed at 2017-07-28T00:41:30Z by Brian Warner <warner@…>
- Owner set to Brian Warner <warner@…>
- Resolution set to fixed
- Status changed from new to closed
In 0386e0d/trunk:
https://github.com/tahoe-lafs/tahoe-lafs/pull/425 is a PR to fix 23 of the 31 current warnings. I'm still working on the remaining 8.