tahoe create-node writes tcp=tor even for i2p

[dawuud]

str4d has found that even without txtorcon installed you can trigger a bug where configuring a storage node via the CLI doesn't work as expected:

tahoe create-node --hide-ip --listen=i2p

tahoe create-client --hide-ip --introducer=i2p:...

these two commands result in the tahoe.cfg being written with:

[connections]
tcp=tor

the subsequent tahoe start command will of course fail.

[warner]

oh, yeah, create_node.py write_node_config() is Tor-centric here:

    if config["hide-ip"]:
        c.write("[connections]\n")
        c.write("tcp = tor\n")
        c.write("\n")

Earlier (in _CreateBaseOptions.postOptions) we allow either tor or i2p to satisfy --hide-ip.

What if we change that tcp=tor clause to try tor_provider._import_txtorcon(), and if that fails, write out tcp=none ? We can't write out tcp=i2p because I2P doesn't let you connect to normal TCP hints.

[str4d]

That to me seems like a sensible default. Perhaps also the create-node command should print which option it has taken, so the user knows to edit it if they want the other option? Then again, it appears very near the top of tahoe.cfg so it's not hard to spot later.

[dawuud]

ok i've attempted the fix that warner mentions:

​https://github.com/tahoe-lafs/tahoe-lafs/pull/392 ​https://github.com/david415/tahoe-lafs/tree/2860.fix_i2p_create_node.0

[Brian Warner <warner@…>]

In 5e1d464/trunk:

Merge branch PR392

closes #392
closes ticket:2860