#2895 closed defect (fixed)

test_servers_of_happiness.py tries to start 5 storage servers but start 8 instead

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: code Version: 1.12.1
Keywords: servers-of-happiness test review-needed Cc:
Launchpad Bug:


This test tries to start up 5 storage servers and then store a file with parameters that will result in unhappiness.

However, the integration test utility code for creating nodes accidentally ignores the storage=False setting for the alice, bob, and flog server nodes - making all three of them storage nodes, too. The result is 8 storage nodes instead of 5.

It's not clear this has a meaningful effect on the outcome of the test but it's clearly not the intent of the author of the code.

Change History (2)

comment:2 Changed at 2017-07-27T16:18:46Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 7cad9e1b/trunk:

Merge PR432: improve servers of happiness integration test

The node creation helper used by the integration tests is now more careful about how it tweaks additional configuration file fields. Previously, it could easily clobber certain settings. Now it should only introduce the specific changes it intends.
Closes ticket:2895

Note: See TracTickets for help on using tickets.