Tahoe backup crashes while collecting file list

[tlhonmey]

Since upgrading to 1.13.0, there is something in some of my filesystems that causes the tahoe backup command to crash. I've not been able to isolate exactly what yet, but some sets of files are fine and some crash before it even starts uploading.

After some experimentation I've discovered that device nodes are one of the things that will trigger the crash. But one of the backup sets on which it crashes doesn't appear to have any, so either I haven't found the hidden one yet, or there is some other special file type that trips it up as well.

Unfortunately the stack trace doesn't offer me any intelligible hints about what file is causing the problem, but I'll include it anyway in the hope that it will make fixing it a little easier.

Traceback (most recent call last):
  File "/usr/lib64/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/lib64/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/twisted/_threads/_threadworker.py", line 46, in work
    task()
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/twisted/_threads/_team.py", line 190, in doWork
    task()
--- <exception caught here> ---
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/twisted/python/threadpool.py", line 250, in inContext
    result = inContext.theWork()
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/twisted/python/threadpool.py", line 266, in <lambda>
    inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/twisted/python/context.py", line 122, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/twisted/python/context.py", line 85, in callWithContext
    return func(*args,**kw)
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/allmydata/scripts/cli.py", line 549, in backup
    rc = tahoe_backup.backup(options)
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 275, in backup
    return bu.run()
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 120, in run
    self.options.filter_listdir,
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 301, in collect_backup_targets
    for child_target in child_targets:
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 301, in collect_backup_targets
    for child_target in child_targets:
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 301, in collect_backup_targets
    for child_target in child_targets:
  File "/home/tahoe/tahoe/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 306, in collect_backup_targets
    yield SpecialTarget(childpath)
exceptions.TypeError: __init__() takes exactly 3 arguments (2 given)
exit code: 1

[exarkun]

Resolved a while ago by ​https://github.com/tahoe-lafs/tahoe-lafs/pull/604 in ​https://github.com/tahoe-lafs/tahoe-lafs/commit/e63ee9b37e91162dc21ae4fe21d7a8303a80a59b