macOS package uploads from buildslave are broken

[exarkun]

The upload-osx-pkg build step fails on the macOS builder. For example, at <​https://tahoe-lafs.org/buildbot-tahoe-lafs/builders/OS-X%2010.13/builds/299/steps/upload-osx-pkg/logs/stdio>:

(view as text)
make upload-osx-pkg
 in dir /private/var/lib/buildslave/bb-tahoe/OS-X_10_13/build (timeout 1200 secs)
 watching logfiles {}
 argv: ['make', 'upload-osx-pkg']
 environment:
  HOME=/var/lib/buildslave
  LOGNAME=buildbot
  PATH=/var/lib/buildslave/.local/bin:/usr/local/bin:/sbin:/usr/sbin:/bin:/usr/bin
  PWD=/private/var/lib/buildslave/bb-tahoe/OS-X_10_13/build
  SHELL=/bin/bash
  SHLVL=1
  TMPDIR=/var/folders/ql/2vmcxkls1tl1w71h9_1wvkch000035/T/
  USER=buildbot
  VERSIONER_PYTHON_PREFER_32_BIT=no
  VERSIONER_PYTHON_VERSION=2.7
  XPC_FLAGS=0x0
  XPC_SERVICE_NAME=0
  _=/var/lib/buildslave/.local/bin/buildslave
  __CF_USER_TEXT_ENCODING=0x65:0:0
 using PTY: False
uploading to ~tahoe-tarballs/OS-X-packages/ via flappserver
flappclient command failed:
[Failure instance: Traceback: <class 'OpenSSL.SSL.Error'>: [('SSL routines', 'ssl3_read_bytes', 'tlsv1 alert unknown ca'), ('SSL routines', 'ssl3_write_bytes', 'ssl handshake failure')]
/var/lib/buildslave/.local/venvs/foolscap/lib/python2.7/site-packages/twisted/internet/selectreactor.py:149:_doReadOrWrite
/var/lib/buildslave/.local/venvs/foolscap/lib/python2.7/site-packages/twisted/internet/tcp.py:209:doRead
/var/lib/buildslave/.local/venvs/foolscap/lib/python2.7/site-packages/twisted/internet/tcp.py:215:_dataReceived
/var/lib/buildslave/.local/venvs/foolscap/lib/python2.7/site-packages/twisted/protocols/tls.py:415:dataReceived
--- <exception caught here> ---
/var/lib/buildslave/.local/venvs/foolscap/lib/python2.7/site-packages/twisted/protocols/tls.py:554:_write
/var/lib/buildslave/.local/venvs/foolscap/lib/python2.7/site-packages/OpenSSL/SSL.py:1271:send
/var/lib/buildslave/.local/venvs/foolscap/lib/python2.7/site-packages/OpenSSL/SSL.py:1187:_raise_ssl_error
/var/lib/buildslave/.local/venvs/foolscap/lib/python2.7/site-packages/OpenSSL/_util.py:48:exception_from_error_queue
]
make: *** [upload-osx-pkg] Error 255
program finished with exit code 2
elapsedTime=1.154855

[exarkun]

I don't think I have access to fix the flappserver and I'm also not sure what the point of these uploads is. Rather than leave the macOS builder failing, I'm disabling the upload part as part of #2962.

[exarkun]

Buildbot has been decommissioned. macOS is now tested by TravisCI and doesn't upload artifacts anywhere.