Opened at 2019-03-07T18:42:01Z
Closed at 2019-03-08T12:47:40Z
#2988 closed defect (fixed)
Many test mixins fail to supercall implementations of hook methods
| Reported by: | exarkun | Owned by: | GitHub <noreply@…> |
|---|---|---|---|
| Priority: | normal | Milestone: | undecided |
| Component: | unknown | Version: | 1.12.1 |
| Keywords: | review-needed | Cc: | |
| Launchpad Bug: |
Description
For example, GridTestMixin.setUp does not supercall. This means you get a kind of random outcome if you happen to mix this in and override setUp.
Ultimately all these mixins should be eliminated. They're a complicated and therefore error-prone way to share functionality. But in the short term, fix them to at least do the correct supercalls.
Change History (2)
comment:1 Changed at 2019-03-07T19:07:38Z by exarkun
- Keywords review-needed added
comment:2 Changed at 2019-03-08T12:47:40Z by GitHub <noreply@…>
- Owner set to GitHub <noreply@…>
- Resolution set to fixed
- Status changed from new to closed
In c45b91e/trunk:
Note: See
TracTickets for help on using
tickets.
https://github.com/tahoe-lafs/tahoe-lafs/pull/564