Opened at 2019-03-15T19:12:58Z

Closed at 2019-03-19T18:23:16Z

#3004 closed defect (fixed)

EliotLoggedRunTest.addCleanup improperly narrows the interface

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: unknown Version: 1.12.1
Keywords: review-needed Cc:
Launchpad Bug:

Description

addCleanup should accept extra positional and keyword arguments and pass them on to the wrapped method. The implementation on this class only accepts a function, though. This breaks interop with various TetsCase?-interacting libraries (for example, Eliot).

Fix the signature.

Change History (3)

comment:1 Changed at 2019-03-15T19:34:34Z by exarkun

We can reduce the hackery in this area once Eliot 1.7 is out by using ​https://github.com/itamarst/eliot/pull/384

comment:3 Changed at 2019-03-19T18:23:16Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In a14d9f6/trunk:

Merge pull request #574 from tahoe-lafs/3004.eliotloggedruntest-addcleanup

Fix Eliot logging integration

Fixes: ticket:3004

Note: See TracTickets for help on using tickets.