Opened at 2019-06-26T14:58:22Z

Closed at 2019-06-26T19:47:42Z

#3111 closed defect (fixed)

do less monkey-patching in allmydata.test.cli.test_start.RunTests.test_run_invalid_config

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: code Version: n/a
Keywords: review-needed Cc:
Launchpad Bug:

Description

This test monkey-patches sys.stdout and sys.stderr. It also has confusing behavior in that it finds output on stdout that is obviously being sent to stderr (clearly I'm wrong because the test passes. nevertheless...)

The code would be simpler and better without the monkey-patching. Also, the test as currently written is in the way of ticket:3053.

Change History (2)

comment:2 Changed at 2019-06-26T19:47:42Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In c169246/trunk:

Merge pull request #627 from tahoe-lafs/3111.test_invalid_section-fixes

Fixes for test_invalid_section

Fixes: ticket:3111

Note: See TracTickets for help on using tickets.