Opened at 2019-08-20T13:30:18Z

Closed at 2019-10-01T18:27:26Z

Last modified at 2019-11-18T13:45:40Z

#3250 closed defect (fixed)

IFoolscapStoragePlugin.get_storage_client cannot actually return a Deferred yet

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: storage economics plugins
Component: unknown Version: n/a
Keywords: review-needed Cc:
Launchpad Bug:

Description

The implementation will be too complicated by supporting Deferreds at the moment. The code is invoked from an __init__ so supporting a Deferred here properly involves re-arranging a lot of how NativeStorageServer works and is used.

For now, just admit defeat and document it as a synchronous interface.

Change History (3)

comment:2 Changed at 2019-10-01T18:27:26Z by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

Merged to integration branch in ​https://github.com/tahoe-lafs/tahoe-lafs/commit/25c476aaa85878692f54f3520180e92e7d6e5b21

comment:3 Changed at 2019-11-18T13:45:40Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>

In 25c476a/trunk:

Merge pull request #654 from tahoe-lafs/3250.synchronous-get_storage_client

Synchronous IFoolscapStoragePlugin.get_storage_client

Fixes: ticket:3250

Note: See TracTickets for help on using tickets.