Opened at 2007-05-04T05:46:53Z
Closed at 2008-02-06T09:50:06Z
#33 closed enhancement (fixed)
add private storage
| Reported by: | zooko | Owned by: | faried |
|---|---|---|---|
| Priority: | minor | Milestone: | eventually |
| Component: | code-frontend-web | Version: | 0.6.0 |
| Keywords: | Cc: | ||
| Launchpad Bug: |
Description
Add the option of storing a file without submitting its URI to the vdrive server.
Attachments (3)
Change History (15)
comment:1 Changed at 2007-05-04T22:12:32Z by faried
Changed at 2007-05-04T22:19:07Z by zooko
comment:2 Changed at 2007-05-04T22:19:51Z by zooko
- Owner changed from somebody to faried
comment:3 Changed at 2007-05-06T20:10:44Z by faried
- Status changed from new to assigned
It works. I'm not sure if it's the right way to do it, but it does upload files without reporting them to the vdrive. It also prints out the URI in the results div on the web page, as well as in twisted.log.
comment:4 Changed at 2007-05-06T20:11:05Z by faried
- Resolution set to fixed
- Status changed from assigned to closed
comment:5 Changed at 2007-05-16T15:59:25Z by zooko
- Resolution fixed deleted
- Status changed from closed to reopened
Oops, I forgot to apply this patch until just now. 78e537de0c77ecd5
Okay, now this one we can definitely unit test. Here is the current code-coverage view of the files touched by this patch:
http://allmydata.org/tahoe-figleaf/figleaf-edgy-187/allmydata.webish.html
Notice that render_results() and uploadprivate() are not completely tested. Oh, and notice that upload() itself isn't, either!
comment:6 Changed at 2007-05-16T16:00:13Z by zooko
- Owner changed from faried to somebody
- Status changed from reopened to new
comment:7 Changed at 2007-06-29T23:16:07Z by zooko
- Owner changed from somebody to faried
Re-assigning to faried in the hopes that he'll write a unit test for it.
comment:8 Changed at 2007-07-02T19:45:22Z by warner
- Priority changed from major to minor
- Version set to 0.4.0
comment:9 Changed at 2007-07-11T22:30:41Z by warner
Given that we now have per-client private directories, is it still useful to expose a web interface to uploading files without attaching them to any directory?
The answer may be yes.. I'm just curious about the use case. If we do have this feature, it should go on a page that is reached from the top-level welcome page, rather than from any particular directory. The directory pages should be reserved for operations that affect their related directory, whereas an unlinked URI-only file upload doesn't involve a directory at all.
comment:10 Changed at 2007-08-14T18:56:12Z by warner
- Component changed from code to code-frontend-web
comment:11 Changed at 2007-09-25T04:27:09Z by zooko
- Milestone set to undecided
- Version changed from 0.4.0 to 0.6.0
comment:12 Changed at 2008-02-06T09:50:06Z by warner
- Resolution set to fixed
- Status changed from new to closed
I've added an upload link from the front welcome page which allows you to upload a file and get back a URI, with no vdrive directories involved at all. I believe that closes this issue.
Patch against webish.py sent to zooko.