Opened at 2020-07-31T11:16:48Z

Closed at 2020-08-07T18:48:55Z

#3362 closed task (fixed)

Add a CI check for tab literals in .py files

Reported by: chadwhitacre Owned by:
Priority: normal Milestone: Support Python 3
Component: dev-infrastructure Version: n/a
Keywords: Cc:
Launchpad Bug:

Description

Acceptance

  1. CI fails if there are tab literals in .py files.
  2. Any existing tab literals in .py files are converted to four spaces.

Change History (6)

comment:1 Changed at 2020-07-31T11:44:01Z by chadwhitacre

Seems like this should be added to the existing codechecks CI step.

comment:2 Changed at 2020-07-31T11:56:48Z by chadwhitacre

No tabs currently, it appears. 

$ find . -name \*.py | grep -v .tox | xargs grep $'\t'
$

comment:3 Changed at 2020-07-31T11:57:48Z by chadwhitacre

Confirmed, by randomly adding a tab and finding it. :) 

$ find . -name \*.py | grep -v .tox | xargs grep $'\t'
./src/allmydata/scripts/tahoe_restart.py:       subcommand_name = "restart"
$

comment:4 Changed at 2020-07-31T12:16:38Z by chadwhitacre

Commits ready to go, waiting for repo perms.

comment:6 Changed at 2020-08-07T18:48:55Z by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in ​https://github.com/tahoe-lafs/tahoe-lafs/commit/1ef25e128cd506856527ba3bfc0519ea9a2ae47b

Note: See TracTickets for help on using tickets.