#3384 closed defect (fixed)

Unpin coverage

Reported by: sajith Owned by: exarkun
Priority: normal Milestone: undecided
Component: dev-infrastructure Version: n/a
Keywords: Cc:
Launchpad Bug:

Description (last modified by sajith)

#3267 pinned some dependencies including coverage, because integration tests were failing on CI. It isn't clear if coverage still needs to remain pinned at ~= 4.5.

Let us unpin coverage and see what happens in CI!

For more context, the follow-up ticket to this would be #3385, which will attempt to use coveralls.io for code coverage checks. We are not entirely satisfied with codecov.io, which we currently use. For example, it is not always clear why codecov checks turn red/disapprove of certain PRs, even when test coverage remains unchanged.

Now, in order to upload coverage reports to codecov.io, we will need to use coveralls-python, which requires that coverage reports should be in coverage 5.0 format. Which is the real motivation for unpinning coverage.

If coveralls.io works better than codecov.io for us, we can switch to the former. Even if it doesn't, this change does not affect codecov: codecov can continue working with the reports we submit in XML format.

(See coverage changelog: "Coverage’s data storage has changed. In version 4.x, .coverage files were basically JSON. Now, they are SQLite databases.")

Change History (8)

comment:1 Changed at 2020-08-18T20:27:28Z by sajith

  • Description modified (diff)

comment:2 Changed at 2020-08-18T20:27:41Z by sajith

  • Description modified (diff)

comment:3 Changed at 2020-08-19T15:22:18Z by sajith

  • Description modified (diff)

comment:4 Changed at 2020-08-19T15:29:57Z by sajith

  • Description modified (diff)

comment:5 Changed at 2020-08-19T15:31:03Z by sajith

  • Description modified (diff)

comment:6 Changed at 2020-08-19T15:33:16Z by sajith

  • Owner set to sajith

comment:7 Changed at 2020-12-29T18:23:05Z by exarkun

  • Owner changed from sajith to exarkun

comment:8 Changed at 2020-12-30T01:36:16Z by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 1bdca90/trunk:

Merge pull request #950 from LeastAuthority?/3384.unpin-coverage

Update coverage pin

Fixes: ticket:3384

Note: See TracTickets for help on using tickets.