Opened at 2020-09-15T22:08:58Z
Closed at 2021-04-02T17:41:53Z
#3418 closed defect (fixed)
coverage.el is uploaded to codecov
| Reported by: | sajith | Owned by: | sajith |
|---|---|---|---|
| Priority: | normal | Milestone: | undecided |
| Component: | unknown | Version: | n/a |
| Keywords: | Cc: | ||
| Launchpad Bug: |
Description
I have seen some instances where running codecov in CircleCI is merely uploading misc/coding_tools/coverage.el (which is definitely not a coverage report!), and not coverage.xml or anything else actually related to code coverage.
I'm not sure if this happens because coverage.xml wasn't generated during some CircleCI runs, or because of any issues with codecov uploader itself. In the more recent CI runs I've looked at, we've been uploading both coverage.xml and coverage.el, so perhaps part of this problem has been already fixed.
I'm not sure uploading coverage.el does any harm, but it can't be doing anything useful either.
See this specific instance, for an example of just coverage.el being uploaded:
- 222735010 (GitHub CI) has coverage.xml: OK.
- 222735010 (GitHub CI) has coverage.xml: OK.
- 27078.0 (CircleCI ubuntu-16.04) has coverage.el, but no coverage.xml: dubious?
- 27076.0 (CircleCI c-locale): ditto
- 27075.0 (CircleCI deprecations): ditto
- 27079.0 (CircleCI ubuntu-18.04): ditto
- 27082.0 (CircleCI debian-8): ditto
- 27080.0 (CircleCI fedora-28): ditto
(This was found when investigating #3391.)
Change History (3)
comment:1 Changed at 2020-09-15T22:22:44Z by sajith
comment:2 Changed at 2020-09-15T22:23:35Z by sajith
- Owner set to sajith
- Status changed from new to assigned
comment:3 Changed at 2021-04-02T17:41:53Z by sajith
- Resolution set to fixed
- Status changed from assigned to closed
Fixed this in https://github.com/codecov/codecov-python/pull/297
Made a pull request against codecov, to make it ignore Emacs lisp files.