Opened at 2020-12-05T14:06:02Z

Closed at 2020-12-06T14:40:17Z

#3547 closed defect (fixed)

Regression in allmydata.test.test_introducer.Announcements.test_client_cache and allmydata.test.test_introducer.ClientSeqnums.test_client

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: unknown Version: n/a
Keywords: review Cc:
Launchpad Bug:

Description

The change for ticket:3504 introduced a Python 3.6 regression: 

===============================================================================
[ERROR]
Traceback (most recent call last):
Failure: testtools.testresult.real._StringException: Empty attachments:
  twisted-log

Traceback (most recent call last):
  File "/home/exarkun/Work/python/tahoe-lafs/.tox/py36/lib/python3.6/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
    result = g.send(result)
  File "/home/exarkun/Work/python/tahoe-lafs/.tox/py36/lib/python3.6/site-packages/allmydata/test/test_introducer.py", line 810, in test_client_cache
    write_introducer(basedir, "default", "nope")
  File "/home/exarkun/Work/python/tahoe-lafs/.tox/py36/lib/python3.6/site-packages/allmydata/scripts/common.py", line 128, in write_introducer
    "furl": furl.decode("ascii"),
AttributeError: 'str' object has no attribute 'decode'


allmydata.test.test_introducer.Announcements.test_client_cache
===============================================================================
[ERROR]
Traceback (most recent call last):
Failure: testtools.testresult.real._StringException: Empty attachments:
  twisted-log

Traceback (most recent call last):
  File "/home/exarkun/Work/python/tahoe-lafs/.tox/py36/lib/python3.6/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
    result = g.send(result)
  File "/home/exarkun/Work/python/tahoe-lafs/.tox/py36/lib/python3.6/site-packages/allmydata/test/test_introducer.py", line 903, in test_client
    write_introducer(basedir, "default", "nope")
  File "/home/exarkun/Work/python/tahoe-lafs/.tox/py36/lib/python3.6/site-packages/allmydata/scripts/common.py", line 128, in write_introducer
    "furl": furl.decode("ascii"),
AttributeError: 'str' object has no attribute 'decode'


allmydata.test.test_introducer.ClientSeqnums.test_client
-------------------------------------------------------------------------------

Change History (2)

comment:2 Changed at 2020-12-06T14:40:17Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 08a36d1/trunk:

Merge pull request #917 from tahoe-lafs/3547.furl-py36-regression

Fix the furl/py36 test suite regression

Fixes: ticket:3547

Note: See TracTickets for help on using tickets.