Opened at 2021-01-01T20:12:26Z

Closed at 2021-01-04T20:28:17Z

#3578 closed defect (fixed)

allmydata.immutable.encode.Encoder._encode_tail_segment is unnecessarily duplicative of _encode_segment

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: unknown Version: n/a
Keywords: Cc:
Launchpad Bug:

Description

This _encode_tail_segment method is an almost-identical copy of the nearby _encode_segment method.

The two differ ever so slightly in their treatment of short reads. However, this could easily be dealt with by a unified function which would be much less complex than the sum of the complexity of these two methods.

Change History (2)

comment:2 Changed at 2021-01-04T20:28:17Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In baaa48a/trunk:

Merge pull request #952 from LeastAuthority?/3578.remove-encode_tail_segment

Remove _encode_tail_segment

Fixes: ticket:3578

Note: See TracTickets for help on using tickets.