#3633 closed defect (fixed)

Use forked txi2p

Reported by: sajith Owned by: sajith
Priority: normal Milestone: undecided
Component: dev-infrastructure Version: n/a
Keywords: Cc:
Launchpad Bug:

Description (last modified by sajith)

There's support for Python 3 on txi2p master branch, but there has not been a release of txi2p that supports Python 3. There are still i2p users of Tahoe-LAFS out there, so we can't drop i2p entirely.

https://pypi.org/project/txi2p-tahoe/ has a forked release of txi2p, with Python 3 support. Tahoe-LAFS could try to use that, at least until txi2p maintainers are back in action.

Change History (3)

comment:1 Changed at 2021-03-10T18:19:24Z by sajith

  • Description modified (diff)

comment:2 Changed at 2021-03-13T19:49:11Z by maylee

Background

txi2p has been forked and lives at https://github.com/sajith/txi2p

Sajith has done cleanup and added testing on the fork.

A few considerations at this time

  • Not known how important i2p is, and therefore whether integration tests are needed.
  • Testing currently takes 15 minutes
  • We would like some reviewers from Tahoe for this package

jaraco recommends that we keep the fork in tahoe-lafs (presumably GitHub? or GitLab?) and that we point PyPI to that repo.

We might be eligible to take over the project as maintainers. We would need to show that we tried to contact Str4d and we would need to show that we couldn't just use the name txi2p-tahoe.

Attempts to contact Str4d

  • Open issue on project repo https://github.com/str4d/txi2p/issues/10, beginning July 1, 2020
  • Email sent to a private address on March 1, 2021
  • Email sent after the fork to the public address on the project's page (PEP's official requirement) March 13, 2021

Need for A Plan

The fork will require long-term maintenance.

  • What about the foolscap? Do we need txi2p back in foolscap?
  • Who will take up maintenance? Who will do code reviews?
  • CI configuration is for Travis. Seems that travis-ci.com (not travis-ci.org) works just fine, for now anyway. Should we move it elsewhere?
  • Should we expand the CI test matrix to include more platforms? (Currently it's just Linux on Travis.)
  • Should we continue to test with unsupported Python (3.5) and really old Twisted (< 20.3 for Python 2.7) versions? (In tox.ini, there's Twisted 10.2 through 21.2, and current, and trunk.)
  • Some dependencies are in pyproject.toml, some are in setup.py. What to do about that?
  • Probably should switch CI badge, coverage badge (uses coveralls), project homepage, etc.
  • Other minor issues: Travis CI does not catch some errors (failures with old versions of Twisted); pypy2 needs cleanup; plugins module is under-tested, etc.

comment:3 Changed at 2021-03-15T13:23:36Z by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 9f31e11/trunk:

Merge pull request #1000 from sajith/3633.use-txi2p-fork

Use forked release of txi2p

Fixes ticket:3633

Note: See TracTickets for help on using tickets.