Opened at 2007-05-04T19:04:27Z
Closed at 2007-05-24T00:28:31Z
#37 closed enhancement (fixed)
web ui does not display size of files in vdrive
| Reported by: | faried | Owned by: | warner |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | code | Version: | 0.2.0 |
| Keywords: | Cc: | ||
| Launchpad Bug: |
Description
The client web interface lists file types (name, type, id, etc), but not the file size.
Attachments (2)
Change History (10)
comment:1 Changed at 2007-05-04T20:21:24Z by faried
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed at 2007-05-04T22:18:18Z by zooko
- Resolution fixed deleted
- Status changed from closed to reopened
Attempting to attach Faried's patch in order to test trac's permissions for storing attachments.
comment:3 Changed at 2007-05-07T02:44:49Z by zooko
- Resolution set to fixed
- Status changed from reopened to closed
fixed by 24d4e072ddbb94da
comment:4 Changed at 2007-05-07T18:16:39Z by warner
unit tests!
comment:5 Changed at 2007-05-16T15:45:42Z by zooko
- Resolution fixed deleted
- Status changed from closed to reopened
http://allmydata.org/tahoe-figleaf/figleaf-edgy-186/allmydata.webish.html
Hm. All the code added by 24d4e072ddbb94da is already covered by the existing unit tests. How could we test it further?
comment:6 Changed at 2007-05-16T15:45:49Z by zooko
- Owner changed from somebody to warner
- Status changed from reopened to new
comment:7 Changed at 2007-05-24T00:23:28Z by warner
test_system.SystemTest._test_web._got_subdir1 should use a regexp to assert that the correct size of the file is present in the HTML page that lists the directory.
I'll take a look at it. I just wanted to encourage us all to think about always adding unit tests along with bugfixes or enhancements. The fact that the code in question is being executed at all during the unit tests is a good sign, but knowing that we have a test which is specifically designed to make sure the code is actually working as intended is much much better.
Having that test *pass* is an added bonus :).
comment:8 Changed at 2007-05-24T00:28:31Z by warner
- Resolution set to fixed
- Status changed from new to closed
- Version set to 0.2.0
done, in 83daa265ba4907bd. Closing for good this time.
Fixed it for now. Tried to attach my patch, but got a perm denied error for /home/trac/projects/tahoe/attachments/ticket, so did a darcs --send zooko.