#3708 closed defect (fixed)

Logging issues in foolscap on Python 3

Reported by: itamarst Owned by: GitHub <noreply@…>
Priority: normal Milestone: Support Python 3
Component: unknown Version: n/a
Keywords: Cc:
Launchpad Bug:

Description

When running integration tests:

}}2021-05-10T10:40:57-0400 [stdout#info] GATHERER: unable to serialize {'facility': 'tahoe.storage_broker', 'format': '%(name)s provided version info %(version)s', 'incarnation': ('86433dff70db2783', None), 'level': 10, 'name': b'q26hhekw', 'num': 626, 'parent': 617, 'time': 1620657650.2063904, 'umid': 'SWmJYg', 'version': {b'application-version': b'tahoe-lafs/1.14.0.post3323', b'http://allmydata.org/tahoe/protocols/storage/v1': {b'available-space': 7235896832, b'delete-mutable-shares-with-zero-length-writev': True, b'fills-holes-with-zero-bytes': True, b'maximum-immutable-share-size': 7235896832, b'maximum-mutable-share-size': 69105000000000000, b'prevents-read-past-end-of-share-data': True, b'tolerates-immutable-read-overrun': True}}}: keys must be a string}

Change History (2)

comment:1 Changed at 2021-07-05T22:40:22Z by itamarst

The underlying bug is in Foolscap, I've opened an issue: https://github.com/warner/foolscap/issues/88

Probably we can ensure we don't pass bytes to Foolscap logging, though, so will see if that's possible.

comment:2 Changed at 2021-07-09T21:27:51Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 8e28a9d/trunk:

Merge pull request #1094 from tahoe-lafs/3708.bytes-logging

Remove bytes from Foolscap logging

Fixes ticket:3708

Note: See TracTickets for help on using tickets.