#3799 closed enhancement (fixed)

Proposal: Rip out all ops other than eq from test vectors in mutable writes

Reported by: itamarst Owned by: exarkun
Priority: normal Milestone: HTTP Storage Protocol
Component: unknown Version: n/a
Keywords: Cc:
Launchpad Bug:


As far as I can tell, the storage client only ever sends "eq" comparisons on tests. The other variants are never used.

I propose:

  1. Disabling all but "eq" on the client side.
  2. Omitting this option altogether from the HTTP protocol, and just support equality.

Change History (2)

comment:1 Changed at 2021-09-14T16:44:26Z by itamarst

Also while we're at, the length field in tests is pointless, per Foolscap docs "you should use length==len(specimen) for everything except nop", and ... nop is not a thing. So that can be removed from the HTTP protocol too.

comment:2 Changed at 2021-09-27T20:57:20Z by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from new to closed

In eb5b6c5/trunk:

Merge pull request #1127 from tahoe-lafs/3799-simplify-IStorageServer

Rip out unnecessary operator logic, and simplify IStorageServer

Fixes ticket:3799

Note: See TracTickets for help on using tickets.