Opened at 2022-05-17T18:10:37Z
Closed at 2022-10-12T21:08:01Z
#3897 closed defect (fixed)
Support for I2P is broken
| Reported by: | exarkun | Owned by: | exarkun |
|---|---|---|---|
| Priority: | normal | Milestone: | undecided |
| Component: | code-network | Version: | n/a |
| Keywords: | Cc: | ||
| Launchpad Bug: |
Description
A user reported that connecting to an introducer using I2P with Tahoe 1.16.0 or 1.17.0 fails with this error:
failed to connect: 'NoneType?' object is not iterable
Apparently a Tahoe-LAFS 1.17.1 introducer can accept connections from Tahoe-LAFS 1.15.1 over I2P.
The user observed the problem when using the Java implementation of I2P.
From my prior investigation (all now completely forgotten, but I have IRC logs) the exception may be raised from txi2p/sam/session.py:36 out of sendSessionCreate from the statement for key in options: because options ends up as None.
The txi2p changeset described as "port to python3" includes a number of changes to default values for parameters named options from None to {} which may or may not be related.
Change History (3)
comment:1 Changed at 2022-05-17T18:12:02Z by exarkun
- Owner set to exarkun
- Status changed from new to assigned
comment:2 Changed at 2022-05-27T17:42:17Z by exarkun
comment:3 Changed at 2022-10-12T21:08:01Z by exarkun
- Resolution set to fixed
- Status changed from assigned to closed
These fixes are merged and released.
This is fixed by https://github.com/tahoe-lafs/txi2p/pull/1 and https://github.com/tahoe-lafs/txi2p/pull/2 and won't need a new Tahoe-LAFS release once those fixes are released, unless we want to update our lower bound to require that the fixes are present.