Opened at 2022-11-27T00:13:43Z
Closed at 2022-11-30T14:58:05Z
#3944 closed task (fixed)
GitHub Actions workflow upkeep
Reported by: | sajith | Owned by: | sajith |
---|---|---|---|
Priority: | normal | Milestone: | undecided |
Component: | dev-infrastructure | Version: | n/a |
Keywords: | Cc: | ||
Launchpad Bug: |
Description
Each run of GitHub Actions with the current configuration emits many warnings about deprecations. Consider this workflow run, for example:
https://github.com/tahoe-lafs/tahoe-lafs/actions/runs/3533138743
There are a 100 warnings, mostly duplicates. The warnings are due to:
- Node.js 12 actions are deprecated. It seems that actions/checkout@v2, actions/setup-python@v2, actions/cache@v2, actions/upload-artifact@v2 all use older Node.js. They are all probably due for an upgrade.
- set-output and save-state commands are deprecated and will be disabled soon. This is from the pip caching steps; we can simply remove that and use the equivalent feature available in newer version of `actions/setup-python.
While we are on this, it probably is a good idea to stick this incantation in the workflow file so that the GITHUB_TOKEN issued at the beginning of the workflow will have a minimum set of permissions:
permissions: contents: read
Relevant GitHub docs are Automatic token authentication and Workflow syntax for GitHub Actions: permissions.
I understand that GH Actions do not get a lot of love from Tahoe-LAFS team, and some of us would love to throw the thing away entirely. However, as long as Tahoe-LAFS uses GH Actions, it is a good idea to do the minimum upkeep.
Change History (2)
comment:1 Changed at 2022-11-27T00:33:58Z by sajith
comment:2 Changed at 2022-11-30T14:58:05Z by GitHub <noreply@…>
- Resolution set to fixed
- Status changed from new to closed
In 7cc023a/trunk:
GitHub Actions: All Actions will begin running on Node16 instead of Node12 is relevant: