Opened at 2023-03-27T17:28:23Z

Closed at 2023-05-01T21:10:01Z

#3999 closed defect (fixed)

The Tor integration tests do incorrect raw string mashing to generate configuration files

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: unknown Version: n/a
Keywords: Cc:
Launchpad Bug:

Description

_create_anonymous_node uses the create-node CLI command and then overwrites the generated tahoe.cfg. This is fragile. And probably already broken, as it fails to preserve at least one important configuration setting - [node]reveal-ip-address = false.

There is another instance of this problem in the tor_introducer fixture.

Do structured configuration manipulation instead.

Change History (2)

comment:1 Changed at 2023-04-25T13:34:52Z by exarkun

It turns out the configuration thus generated for the Tor introducer was actually wrong and failed to make it a Tor-only introducer. Then, the Tor integration tests passed by connecting to the introducer over TCP instead, preventing the tests from exercising Tor support in the introducer - which was broken!

So this will also come for a fix for those issues as well.

comment:2 Changed at 2023-05-01T21:10:01Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 1d92d9f/trunk:

Merge pull request #1278 from exarkun/3999.structure-config-manipulation

Safely customize the Tor introducer's configuration

Fixes: ticket:3999

Note: See TracTickets for help on using tickets.