#473 closed defect (fixed)

_paused_at exception in stopped download

Reported by: warner Owned by:
Priority: minor Milestone: 1.3.0
Component: code-encoding Version: 1.1.0
Keywords: Cc:
Launchpad Bug:

Description

There's a bug in web downloads: when someone halts the download (by hitting Stop on their browser and thus closing the HTTP connection), the client dumps an exception to the twisted log. The problem is that the _paused_at attribute is being used without a guard that makes sure it was first initialized.

I don't think this is likely to cause significant problems, as it occurs after the client has abandoned their download anyways. Worst case it might cause the Download object to stick around forever, but I suspect that it gets gc'ed pretty quickly. So it's probably just noise in the logs.

Both resumeProducing and stopProducing need to update the time-spent-paused timer in clauses that are guarded by if self._paused

Change History (2)

comment:1 Changed at 2008-08-05T19:17:47Z by warner

  • Milestone changed from undecided to 1.2.1
  • Resolution set to fixed
  • Status changed from new to closed

This was fixed in fd465b4aaf179677, before the 1.2.0 release, but a related problem (self._paused being used during registerProducer before it was initialized) was not fixed until cd4d3cdeeacca0aa, after the 1.2.0 release. So I'll mark this one as fixed, but for the 1.2.1 milestone.

comment:2 Changed at 2008-09-03T01:17:41Z by warner

  • Milestone changed from 1.3.1 to 1.3.0
Note: See TracTickets for help on using tickets.