#520 closed defect (fixed)
indicate size limits early in helper protocol
Reported by: | warner | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | undecided |
Component: | code-encoding | Version: | 1.2.0 |
Keywords: | helper | Cc: | |
Launchpad Bug: |
Description
We currently have a roughly 12GB limit on the size of an immutable file. Attempting to upload something larger than this will fail.
The helper, however, doesn't tell clients about this early: they'll push the entire ciphertext to the helper, and only then will they get an error message.
The task is: clearly define what the size limit is, expose it in the uploader code (perhaps uploader.get_max_file_size()), have the helper check it, have the helper return an error to the client if they ask to send a file larger than it.
Change History (4)
comment:1 Changed at 2008-09-22T19:57:31Z by zooko
comment:2 Changed at 2008-12-07T20:41:34Z by warner
this is biting us on the allmydata.com prodnet again. Some clients are attempting to upload 18GB+ files, which are doomed to failure, and also overflow the helper's disk.
comment:3 Changed at 2009-02-24T05:12:50Z by zooko
- Resolution set to fixed
- Status changed from new to closed
I guess we don't need to do this because now there are no limits on immutable upload file size. Hooray!
comment:4 Changed at 2009-02-24T05:14:14Z by zooko
P.S. Where by "No limits" I mean up to somewhere in the neighborhood of 264 bytes.
see also #346 (increase share-size field to 8 bytes, remove 12GiB filesize limit) and #320 (add streaming upload to HTTP interface)