Opened at 2009-02-11T20:42:57Z

Last modified at 2021-03-30T18:40:19Z

#622 assigned enhancement

add a 'repair' button on the webapi checker results page

Reported by: warner Owned by: Lcstyle
Priority: major Milestone: soon
Component: code-frontend-web Version: 1.2.0
Keywords: repair verify easy usability wui Cc:
Launchpad Bug:

Description (last modified by Lcstyle)

The "Repair" button appears when the checker results indicate an unhealthy file. But the target URL that it points at is wrong, so clicking on it doesn't do anything.

Change History (20)

comment:1 Changed at 2009-04-09T23:12:45Z by zooko

I'm going to find and comment-out the Repair button on the check-results-page for 1.4.0, then move this ticket ahead to Milestone 1.4.1. If someone else comments-out that button or otherwise fixes this before I get around to that (likely late tonight or tomorrow morning) then that's cool.

comment:2 Changed at 2009-04-09T23:49:25Z by warner

I'll get it.

comment:3 Changed at 2009-04-10T21:32:32Z by warner

code patched.. the button is commented out.

I think the bug might be related to files vs directories: the URL of the check-results page will look like FILECAP?t=check for files, and DIRCAP/?t=check for directories, so the relative link to the repair URL needs to be different (FILECAP?t=check&repair=true for files, and just ?t=check&repair=true for directories). Or, we should point directly at /uri/CAP?t=check for both, instead of trying to use a relative link. Well, except that we always want some kind of relative link, otherwise things break when you've got a proxy in front of the webapi server.

comment:4 Changed at 2009-04-11T14:01:57Z by zooko

  • Milestone changed from 1.4.0 to 1.4.1

The button is comment out, and I'm moving this ticket to Milestone 1.4.1.

comment:5 Changed at 2010-01-26T15:41:36Z by zooko

  • Milestone changed from 1.6.0 to eventually

comment:6 Changed at 2010-01-26T15:42:46Z by zooko

  • Keywords repair verify easy added

comment:7 Changed at 2010-02-11T01:27:06Z by davidsarah

  • Milestone changed from eventually to 1.7.0

comment:8 Changed at 2010-02-11T01:27:46Z by davidsarah

  • Keywords usability wui added

comment:9 Changed at 2010-02-15T19:54:34Z by davidsarah

  • Milestone changed from 1.7.0 to 1.6.1

comment:10 Changed at 2010-02-16T05:21:41Z by zooko

  • Milestone changed from 1.6.1 to 1.7.0
  • Summary changed from 'repair' button on the webapi checker results page doesn't work to add a 'repair' button on the webapi checker results page

I think this is a new feature rather than a bugfix (since the button is absent, rather than broken, in v1.6.0).

comment:11 Changed at 2010-06-18T23:48:21Z by zooko

  • Milestone changed from 1.7.0 to eventually

comment:12 Changed at 2014-09-27T02:30:59Z by Lcstyle

  • Description modified (diff)
  • Owner set to Lcstyle
  • Status changed from new to assigned

comment:13 Changed at 2014-09-27T03:15:58Z by Lcstyle

  • Milestone changed from eventually to 1.11.0

comment:14 Changed at 2014-09-27T13:44:02Z by daira

  • Milestone changed from 1.11.0 to 1.12.0
  • Type changed from defect to enhancement

1.11 is frozen for work on new tickets, but please feel free to work on this for 1.12.

comment:15 Changed at 2014-10-01T02:09:55Z by Lcstyle

Since this is the only "major" priority issue I've assigned to myself, I've decided to work on it next. Since 1382 is hopefully making it into 1.11 (and part of 1382 is of course: "Extend servers of happiness to file check, verify, and repair operations;"), it would be nice to have this repair button work properly. I've found the original diff here: ​https://github.com/tahoe-lafs/tahoe-lafs/commit/54952e9beacdbe20590221341f89b3b2246aa9bc#diff-0595565110d5f14254df062f4b0e3726

It'd be nice to have some additional color on this issue before I begin, if any can be provided by anyone?

comment:16 Changed at 2014-10-02T01:06:45Z by daira

I would suggest undoing [54952e9beacdbe20590221341f89b3b2246aa9bc] on a branch, then adding a test that checks the HTML for whether the button submit URL is correct (once you've worked out what it should be).

comment:17 Changed at 2016-03-22T05:02:25Z by warner

  • Milestone changed from 1.12.0 to 1.13.0

Milestone renamed

comment:18 Changed at 2016-06-28T18:17:14Z by warner

  • Milestone changed from 1.13.0 to 1.14.0

renaming milestone

comment:19 Changed at 2020-06-30T14:45:13Z by exarkun

  • Milestone changed from 1.14.0 to 1.15.0

Moving open issues out of closed milestones.

comment:20 Changed at 2021-03-30T18:40:19Z by meejah

  • Milestone changed from 1.15.0 to soon

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.