Opened at 2009-05-03T20:41:35Z
Closed at 2009-05-27T02:12:49Z
#692 closed enhancement (fixed)
(patch) improve appearance of welcome and directory pages
| Reported by: | kpreid | Owned by: | zooko |
|---|---|---|---|
| Priority: | minor | Milestone: | undecided |
| Component: | code-frontend-web | Version: | 1.4.1 |
| Keywords: | stylesheet, wui, appearance | Cc: | kpreid, francois |
| Launchpad Bug: |
Description
After installing Tahoe, I decided that the welcome and directory pages could easily be improved in appearance. This set of patches does so, with a few other fixes/comments as well.
Fri May 1 15:10:50 EDT 2009 Kevin Reid <kpreid@…>
- Fix broken link from Provisioning to Reliability page.
Sun May 3 16:25:33 EDT 2009 Kevin Reid <kpreid@…>
- Link all Tahoe web pages to the /tahoe_css stylesheet which already exists.
Sun May 3 16:28:02 EDT 2009 Kevin Reid <kpreid@…>
- Modify markup of Tahoe web pages to be more amenable to styling; some minor changes of wording.
Sun May 3 16:31:42 EDT 2009 Kevin Reid <kpreid@…>
- Add CSS styles to spiff up the Tahoe WUI's appearance, particularly the welcome page and directories.
Sun May 3 16:33:25 EDT 2009 Kevin Reid <kpreid@…>
- Tweak wording in directory page: not-read-only is "modifiable", mention creating a directory _in this directory_.
Sun May 3 16:34:42 EDT 2009 Kevin Reid <kpreid@…>
- Comment on duplication of code/markup found during styling project.
Attachments (3)
Change History (11)
Changed at 2009-05-03T20:41:52Z by kpreid
comment:1 Changed at 2009-05-04T15:22:03Z by francois
Changed at 2009-05-04T15:22:43Z by francois
comment:2 Changed at 2009-05-04T23:00:52Z by warner
- Keywords review added
comment:3 Changed at 2009-05-05T00:57:04Z by zooko
- Keywords review removed
Oh, fdz tried it and reported a bug, so I'm unsetting the "review" keyword until Kevin (or someone) fixes that. I know that Kevin is in the mode of contributing such things only on spur-of-the-moment rather than on a schedule, so if someone other than Kevin wants to fix that bug, just put your name in "Owner" when you start working on it. Also, we need a unit test that triggers that bug that fdz found by manual experimentation.
comment:4 Changed at 2009-05-20T21:32:32Z by kpreid
- Cc kpreid added
Is it possible that francois (fdz?) applied the patch but didn't rebuild? From my experience, Tahoe reads the HTML template files direct from the source tree, but the python code needs a rebuild to take effect, so applying my patch (which adds a slot so named) would have the effect of producing that error.
comment:5 Changed at 2009-05-20T22:13:30Z by zooko
- Cc francois added
comment:6 Changed at 2009-05-22T09:35:11Z by francois
Yes, my bad, I did not rebuilt tahoe after applying your patch. Forget about my previous comment.
BTW, this CSS makes Tahoe look way better !
comment:7 Changed at 2009-05-26T23:32:51Z by kpreid
- Owner set to zooko
comment:8 Changed at 2009-05-27T02:12:49Z by zooko
- Resolution set to fixed
- Status changed from new to closed
Fixed by 2f3842954bebe4a3, 35d3671f4efe8f7b, d0b4fd4689bb3386, 3e80676a299fe3ed, a71c914e50981ab2, 23441389a572f6a3. Commemorated by 01fdd5283445cfd9. Thanks, Kevin!
Applying your patches to tahoe-1.4.1-r3857 (trunk as of today) leads to the following exception when I try to access Tahoe's homepage at http://localhost:3456/.