#740 closed enhancement (fixed)

tahoe deep-check should take multiple arguments

Reported by: kpreid Owned by: daira
Priority: minor Milestone: 1.10.1
Component: code-frontend-cli Version: 1.4.1
Keywords: usability cli easy tahoe-deepcheck tahoe-check Cc: kpreid
Launchpad Bug:

Description (last modified by markberger)

What I did: tahoe deep-check --repair foo: bar:

What I expected: All designated directories to be checked and repaired.

What happened instead: tahoe: Wrong number of arguments.

Change History (16)

comment:1 Changed at 2009-06-19T21:51:53Z by kpreid

  • Cc kpreid added

comment:2 Changed at 2011-05-20T23:43:06Z by davidsarah

  • Keywords usability cli easy added
  • Milestone changed from undecided to eventually

comment:3 Changed at 2011-05-20T23:54:00Z by davidsarah

  • Keywords tahoe-deepcheck tahoe-check added

This applies to both tahoe deep-check and tahoe check, both implemented in src/allmydata/scripts/tahoe_check.py.

options.where, which is set here and here in cli.py, needs to be a list of ALIAS:PATH arguments, and then the check function and DeepCheckStreamer.run in tahoe_check.py need to loop over this list.

Last edited at 2011-05-20T23:54:45Z by davidsarah (previous) (diff)

comment:4 Changed at 2013-04-22T19:27:10Z by daira

  • Keywords review-needed added
  • Milestone changed from eventually to soon

markberger added a pull request here: https://github.com/tahoe-lafs/tahoe-lafs/pull/41.

comment:5 Changed at 2013-04-22T19:43:07Z by daira

  • Keywords test-needed added; review-needed removed
  • Owner set to markberger

I commented on the pull request.

comment:6 Changed at 2013-05-14T05:50:05Z by markberger

  • Description modified (diff)

The feature now passes all existing tests and I've added a unit test to test_cli.py for multiple aliases. Please refer to the same pull request.

comment:7 Changed at 2013-05-14T21:43:41Z by zooko

Wow! I missed this when comment:4 was posted 3 weeks ago. I wonder what else I've missed from the trac timeline. ☹

comment:8 Changed at 2013-05-15T17:24:26Z by zooko

  • Keywords review-needed added; test-needed removed

removing the test-needed keyword and adding the review-needed keyword

comment:9 follow-up: Changed at 2013-05-15T17:44:07Z by zooko

  • Keywords test-needed added; review-needed removed

I added a review comment requesting that the test be made more demanding. Removing review-needed and putting back test-needed.

comment:10 Changed at 2013-05-30T15:56:49Z by zooko

markberger rebased this to trunk and opened a new pull request: https://github.com/tahoe-lafs/tahoe-lafs/pull/47

comment:11 Changed at 2013-05-30T17:15:35Z by markberger

After some help I was able to rebase the patch to the current trunk and place the patch on its own branch. The new pull request is here: https://github.com/tahoe-lafs/tahoe-lafs/pull/48. Additional tests still need to be written.

comment:12 Changed at 2013-05-30T18:55:39Z by daira

  • Owner changed from markberger to daira
  • Status changed from new to assigned


comment:13 Changed at 2013-07-26T19:02:55Z by markberger

I squashed the commit history on the pull request.

comment:14 Changed at 2013-08-02T02:37:29Z by daira

  • Keywords reviewed added; test-needed removed
  • Milestone changed from soon to 1.11.0
  • Status changed from assigned to new

Will commit.

comment:15 in reply to: ↑ 9 Changed at 2013-08-02T02:39:00Z by daira

Replying to zooko:

I added a review comment requesting that the test be made more demanding.

I checked that the current test addresses this.

comment:16 Changed at 2013-08-27T15:16:40Z by zooko

  • Keywords reviewed removed
  • Resolution set to fixed
  • Status changed from new to closed


Note: See TracTickets for help on using tickets.