Opened at 2009-06-19T20:53:46Z
Last modified at 2013-08-27T15:16:40Z
#740 closed enhancement
tahoe deep-check should take multiple arguments — at Version 6
| Reported by: | kpreid | Owned by: | markberger |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.10.1 |
| Component: | code-frontend-cli | Version: | 1.4.1 |
| Keywords: | usability cli easy tahoe-deepcheck tahoe-check | Cc: | kpreid |
| Launchpad Bug: |
Description (last modified by markberger)
What I did: tahoe deep-check --repair foo: bar:
What I expected: All designated directories to be checked and repaired.
What happened instead: tahoe: Wrong number of arguments.
Change History (6)
comment:1 Changed at 2009-06-19T21:51:53Z by kpreid
- Cc kpreid added
comment:2 Changed at 2011-05-20T23:43:06Z by davidsarah
- Keywords usability cli easy added
- Milestone changed from undecided to eventually
comment:3 Changed at 2011-05-20T23:54:00Z by davidsarah
- Keywords tahoe-deepcheck tahoe-check added
comment:4 Changed at 2013-04-22T19:27:10Z by daira
- Keywords review-needed added
- Milestone changed from eventually to soon
markberger added a pull request here: https://github.com/tahoe-lafs/tahoe-lafs/pull/41.
comment:5 Changed at 2013-04-22T19:43:07Z by daira
- Keywords test-needed added; review-needed removed
- Owner set to markberger
I commented on the pull request.
comment:6 Changed at 2013-05-14T05:50:05Z by markberger
- Description modified (diff)
The feature now passes all existing tests and I've added a unit test to test_cli.py for multiple aliases. Please refer to the same pull request.
Note: See
TracTickets for help on using
tickets.
This applies to both tahoe deep-check and tahoe check, both implemented in src/allmydata/scripts/tahoe_check.py.
options.where, which is set here and here in cli.py, needs to be a list of ALIAS:PATH arguments, and then the check function and DeepCheckStreamer.run in tahoe_check.py need to loop over this list.