Opened at 2009-07-25T18:53:12Z
Closed at 2014-01-17T23:28:38Z
#775 closed defect (cannot reproduce)
no pycrypto + authorized_keys file should refuse to start with a clear error message about why
| Reported by: | zooko | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | soon |
| Component: | code-nodeadmin | Version: | 1.4.1 |
| Keywords: | usability error pycrypto-lib | Cc: | zancas |
| Launchpad Bug: |
Description
In #522, RobK reports that if you don't have pycrypto installed and you have an authorized_keys.* file in your Tahoe-LAFS base dir that "an explosion ensues". Does the node fail to start? We should make sure that the node starts even in this case.
Change History (9)
comment:1 Changed at 2009-07-28T21:57:11Z by warner
comment:2 Changed at 2009-07-28T22:47:41Z by zooko
Okay, I agree, it should fail to start up (with a useful error message). See also #774 (pycrypto package is required for manhole).
comment:3 Changed at 2009-12-12T03:28:58Z by zooko
- Summary changed from no pycrypto + authorized_keys file = failure to start? to no pycrypto + authorized_keys file should refuse to start with a clear error message about why
comment:4 Changed at 2010-01-16T01:27:25Z by davidsarah
- Keywords usability error pycrypto added
comment:5 Changed at 2010-02-15T19:10:35Z by davidsarah
- Keywords pycrypto-lib added; pycrypto removed
- Milestone changed from undecided to 1.7.0
Part of #953.
comment:6 Changed at 2010-06-18T23:27:50Z by zooko
- Milestone changed from 1.7.0 to soon
comment:7 Changed at 2011-08-18T03:50:22Z by zooko
- Cc zancas added
comment:8 Changed at 2011-08-18T04:13:12Z by davidsarah
The dependency on PyCrypto is currently unconditional (i.e. Tahoe will fail to build if a compatible version of PyCrypto can't be built). I think that at the time this ticket was filed, it was an optional dependency. So this ticket is probably now invalid.
(Whether PyCrypto should be an unconditional dependency is another matter; I'd love to get rid of it. See http://twistedmatrix.com/trac/ticket/4633.)
comment:9 Changed at 2014-01-17T23:28:38Z by daira
- Resolution set to cannot reproduce
- Status changed from new to closed
oh, I'm not sure. Having configuration problems cause a clear startup failure might be better than having the node start but then fail to do something later. We could wrap the import statement and emit a prettier message, but I think I'd prefer an exception at "tahoe start" time to a log message buried in logs/twistd.log.
What does the "explosion" look like?