make check-memory is broken

[zooko]

When I run make check-memory it says

PYTHONPATH="/usr/local/lib/python2.5/site-packages/:/Users/wonwinmcbrootles/playground/allmydata/tahoe/instdir/lib" python src/allmydata/test/check_memory.py
STARTING
[Failure instance: Traceback: <type 'exceptions.TypeError'>: create_client() takes at least 2 arguments (1 given)
/lib/python2.5/site-packages/twisted/internet/base.py:561:runUntilCurrent
/Users/wonwinmcbrootles/playground/allmydata/tahoe/instdir/lib/foolscap/eventual.py:26:_turn
/lib/python2.5/site-packages/twisted/internet/defer.py:239:callback
/lib/python2.5/site-packages/twisted/internet/defer.py:304:_startRunCallbacks
--- <exception caught here> ---
/lib/python2.5/site-packages/twisted/internet/defer.py:317:_runCallbacks
src/allmydata/test/check_memory.py:52:_more
src/allmydata/test/check_memory.py:128:start_client
]

Brian recently mentioned that he wanted to fix this.

[zooko]

Brian also plans to make beautiful munin graphs (e.g. ​http://allmydata.org/tahoe-munin/tahoebs1.allmydata.com-tahoe_files.html) for memory usage over time or over versions. :-)

[warner]

I've added links to the munin graphs in the "Memory Footprint" link in the [Dev Dev page]. And we have the buildbot running memory-footprint tests on every checkin: ​http://allmydata.org/buildbot?show=memcheck

The memory tests will be enhanced (starting with uploading a 50MB file) once we get some dedicated hardware.. right now it's poor zandr's workstation running them.

So I think we can close this one now.