#811 closed defect (fixed)

fix fuse impl_c a.k.a. blackmatch

Reported by: zooko Owned by: francois
Priority: major Milestone: 1.6.0
Component: code-frontend Version: 1.5.0
Keywords: reviewed fuse Cc:
Launchpad Bug:


Thomas Delaet contributed a patch to make fuse impl_c a.k.a. blackmatch work:


I've downloaded his patch from that email and attached it to this ticket. Please review and apply!

Attachments (2)

fix_blackmatch.patch.txt (2.0 KB) - added by zooko at 2009-10-02T16:25:13Z.
fix_blackmatch-2.patch.txt (1.8 KB) - added by francois at 2009-12-29T23:59:02Z.

Download all attachments as: .zip

Change History (7)

Changed at 2009-10-02T16:25:13Z by zooko

comment:1 Changed at 2009-12-21T02:53:32Z by davidsarah

  • Keywords review-needed added; review removed

comment:2 Changed at 2009-12-29T23:58:47Z by francois

  • Milestone changed from undecided to 1.6.0
  • Owner set to francois

I've just tested this patch on latest trunk and it really does make the blackmatch implementation work again, so it should be included in the next Tahoe release.

The initial breakage was due to this patch:

Sat Jul 18 00:15:49 CEST 2009  Brian Warner <warner@lothar.com>
  * rename NewDirectoryNode to DirectoryNode, NewDirectoryURI to DirectoryURI

The test in the parsing of the '--root-uri' option is commented by the initial patch and I don't really see why because the test worked during my tests. What do you think about keeping it uncommented ? I'll attach a new patch with this modification.

        # test the uri for structural validity:
            raise usage.error('root-uri must be a valid directory uri (not %r)' % (root_uri,))

Changed at 2009-12-29T23:59:02Z by francois

comment:3 Changed at 2009-12-30T00:12:36Z by francois

  • Keywords reviewed added; review-needed removed

comment:4 Changed at 2009-12-30T04:08:10Z by warner

keeping the DirectoryURI.init_from_string(root_uri) test is probably ok. I'd like to reduce the use of things like DirectoryURI in the future, but it's probably ok for the near-term.

Sorry about breaking that.. I grepped through src/ for users of those symbols, but I didn't think to grep through misc/ too.. I'd assumed that everything there was speaking webapi rather than importing tahoe code directly.

comment:5 Changed at 2010-01-09T20:34:35Z by zooko

  • Resolution set to fixed
  • Status changed from new to closed

fixed by eb9358ff6de5cd23

Note: See TracTickets for help on using tickets.