#817 closed defect (fixed)

inconsistent Recent Operations Status - Done/Finished

Reported by: terrell Owned by:
Priority: minor Milestone: 1.6.0
Component: code-frontend-web Version: 1.5.0
Keywords: easy review Cc:
Launchpad Bug:


The grid status page shows inconsistent results for the Status column under Recent Operations. See attached window capture of http://testgrid.allmydata.org:3567/status/ below.

Most completed operations are marked 'Done'.

Some are marked 'Finished'.

I would guess that to close this ticket, the status words should be consistent across different actions to remove ambiguity and any suggested semantic difference in status.

Attachments (3)

done_vs_finished.png (250.7 KB) - added by terrell at 2009-10-22T16:29:38Z.
ticket817.darcspatch.txt (1.1 KB) - added by davidsarah at 2009-11-08T04:49:57Z.
Patch to make status of finished operations consistently "Finished"
ticket817-2.darcspatch.txt (19.9 KB) - added by davidsarah at 2009-11-21T06:22:53Z.
make status of finished operations consistently "Finished"

Download all attachments as: .zip

Change History (7)

Changed at 2009-10-22T16:29:38Z by terrell

comment:1 Changed at 2009-10-23T20:50:41Z by zooko

  • Keywords easy added

comment:2 Changed at 2009-11-08T04:48:27Z by davidsarah

  • Keywords review added
  • Milestone changed from undecided to 1.6.0

The patch I'm about to attach uses "Finished". (To me, "Done" implies that a side effect has happened, while "Finished" works for both side-effecting and read-only operations.)

Changed at 2009-11-08T04:49:57Z by davidsarah

Patch to make status of finished operations consistently "Finished"

Changed at 2009-11-21T06:22:53Z by davidsarah

make status of finished operations consistently "Finished"

comment:3 Changed at 2009-11-21T06:23:40Z by davidsarah

The previous attachment was a diff, not a darcs patch.

comment:4 Changed at 2009-11-28T21:25:51Z by warner

  • Resolution set to fixed
  • Status changed from new to closed

Committed, in c4d38ad4c56233e3. Thanks!

Note: See TracTickets for help on using tickets.